Skip to content

Fix miniSEED matcher attribute defaults - #964

Merged
wangyinz merged 1 commit into
masterfrom
codex/issue-825-matcher-defaults
Aug 23, 2026
Merged

wangyinz merged 1 commit into
masterfrom
codex/issue-825-matcher-defaults

Conversation

@wangyinz

Copy link
Copy Markdown
Member

Fixes #825

This PR removes shared mutable default state from both miniSEED matchers and copies every caller-provided iterable before adding channel-only attributes.

Validation includes an independent agent review, MongoDB 8.0.29 adjacent regressions, an exact baseline-red suite, input immutability checks for lists/tuples/iterators, Black, py_compile, Ruff, and diff checks.

This PR is ready for human review. It must not be merged automatically.

@codecov

codecov Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.20%. Comparing base (83034b9) to head (f708b5b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
+ Coverage   72.14%   72.20%   +0.05%     
==========================================
  Files         182      182              
  Lines       36089    36090       +1     
  Branches     2532     2532              
==========================================
+ Hits        26037    26057      +20     
+ Misses       9146     9127      -19     
  Partials      906      906              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangyinz
wangyinz marked this pull request as draft August 14, 2026 06:02
@wangyinz
wangyinz marked this pull request as ready for review August 14, 2026 15:43
@wangyinz
wangyinz force-pushed the codex/issue-825-matcher-defaults branch from de1b836 to f708b5b Compare August 23, 2026 08:39
@wangyinz
wangyinz merged commit a0c0ba2 into master Aug 23, 2026
18 checks passed
@wangyinz
wangyinz deleted the codex/issue-825-matcher-defaults branch August 23, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove mutable default state from miniSEED normalize matchers

1 participant