Skip to content

Honor optional global_history in distributed wrappers - #980

Merged
wangyinz merged 2 commits into
masterfrom
codex/issue-838-global-history-optional
Aug 24, 2026
Merged

wangyinz merged 2 commits into
masterfrom
codex/issue-838-global-history-optional

Conversation

@wangyinz

@wangyinz wangyinz commented Aug 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Resolve and log global history only when a requested history mode needs it.
  • Preserve explicit algorithm IDs and use one manager lookup, one log operation, and one invocation ID per call.
  • Avoid history allocation and database side effects when all history modes are disabled.
  • Add wrapper-level regression coverage.

Closes #838

@codecov

codecov Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.22%. Comparing base (4aa2cf0) to head (891ebdd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage   73.18%   73.22%   +0.04%     
==========================================
  Files         182      182              
  Lines       36176    36165      -11     
  Branches     2532     2532              
==========================================
+ Hits        26474    26481       +7     
+ Misses       8797     8779      -18     
  Partials      905      905              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangyinz
wangyinz marked this pull request as draft August 14, 2026 06:03
@wangyinz
wangyinz marked this pull request as ready for review August 14, 2026 15:43
@wangyinz
wangyinz force-pushed the codex/issue-838-global-history-optional branch from 43955e5 to 891ebdd Compare August 24, 2026 07:07
@wangyinz

Copy link
Copy Markdown
Member Author

Review result: ready to merge after CI. The wrappers now preserve an explicit algorithm ID, perform at most one registry lookup and one global-history log per invocation, and reuse the same ID for object history. With both global and object history disabled, they allocate no ID and make no history-database call. The dedicated contract suite passes locally (37 tests).

@wangyinz
wangyinz merged commit 214f0da into master Aug 24, 2026
18 checks passed
@wangyinz
wangyinz deleted the codex/issue-838-global-history-optional branch August 24, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Honor optional global_history in distributed wrappers

1 participant