Repository navigation
Honor optional global_history in distributed wrappers - #980
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #980 +/- ##
==========================================
+ Coverage 73.18% 73.22% +0.04%
==========================================
Files 182 182
Lines 36176 36165 -11
Branches 2532 2532
==========================================
+ Hits 26474 26481 +7
+ Misses 8797 8779 -18
Partials 905 905 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wangyinz
marked this pull request as draft
August 14, 2026 06:03
wangyinz
marked this pull request as ready for review
August 14, 2026 15:43
wangyinz
force-pushed
the
codex/issue-838-global-history-optional
branch
from
August 24, 2026 07:07
43955e5 to
891ebdd
Compare
Member
Author
|
Review result: ready to merge after CI. The wrappers now preserve an explicit algorithm ID, perform at most one registry lookup and one global-history log per invocation, and reuse the same ID for object history. With both global and object history disabled, they allocate no ID and make no history-database call. The dedicated contract suite passes locally (37 tests). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #838