Repository navigation
Fix MCXcor convergence and option handling - #983
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 71.48% 71.50% +0.01%
==========================================
Files 182 182
Lines 35666 35667 +1
Branches 2532 2532
==========================================
+ Hits 25496 25502 +6
+ Misses 9264 9259 -5
Partials 906 906 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wangyinz
marked this pull request as draft
August 14, 2026 06:04
wangyinz
marked this pull request as ready for review
August 14, 2026 15:40
wangyinz
force-pushed
the
codex/issue-854-mcxcor-convergence
branch
from
August 22, 2026 07:23
20a893c to
650cec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #854
What changed
Root cause and impact
The convergence loop aliased stack state, had an unreachable exhaustion check, and ignored documented options. This could falsely report convergence, silently continue after exhaustion, or initialize from the wrong stack.
Validation
py_compile,git diff --check, and Sphinx dummy build: passedThis PR is ready for human review and is intentionally not merged.