617 address create time resolution - #618
Merged
Merged
Conversation
…ndows build issue with the *NIX includes for utilities
…nect/cppagent into 617_address_create_time_resolution
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
There are confirmed test-code memory leaks (unfreed new[]/new) and potentially brittle Conan CMake tool version gating that should be resolved before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR primarily performs a broad C++ formatting/const-correctness style pass (pointer/reference spacing and signature tweaks) across tests and core library headers/sources, alongside a few build/tooling updates (Conan CMake tool requirements and version bumps).
Changes:
- Apply consistent pointer/reference spacing and signature normalization across
test_package/andsrc/mtconnect/. - Update Conan VS/macOS profiles to require newer CMake tool versions; bump agent version in
CMakeLists.txt. - Add/adjust a few includes and small behavior tweaks (e.g.,
message_mapper.hppdependency include; logging level change).
File summaries
| File | Description |
|---|---|
| test_package/xml_printer_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/utilities_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/url_parser_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/unit_conversion_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/timestamp_extractor_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/testsink_service.hpp | Formatting/signature spacing normalization in test service |
| test_package/testadapter_service.hpp | Formatting/signature spacing normalization in test service |
| test_package/task_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/target_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/specification_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/solid_model_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/shdr_tokenizer_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/sensor_configuration_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/routing_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/response_document_test.cpp | Formatting + (introduced) RAII opportunity for file buffer |
| test_package/relationship_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/references_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/raw_material_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/qname_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/qif_document_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/pipeline_edit_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/pipeline_deliver_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/physical_asset_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/part_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/pallet_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/observation_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/mtconnect_xml_transform_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/mqtt_isolated_test.cpp | Formatting + (introduced) heap allocations now visible for cleanup |
| test_package/mqtt_adapter_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/message_mapping_test.cpp | Include ordering adjusted; comment now inconsistent with ordering |
| test_package/kinematics_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/json_printer_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/json_printer_stream_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/json_printer_probe_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/json_printer_error_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/json_printer_asset_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/json_parser_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/json_helper.hpp | Formatting/signature spacing normalization in test helpers |
| test_package/json_device_parser_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/image_file_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/fixture_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/file_cache_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/file_asset_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/entity_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/entity_printer_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/entity_parser_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/duplicate_filter_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/device_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/data_set_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/data_item_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/cutting_tool_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/correct_timestamp_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/coordinate_system_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/connector_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/config_parser_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/composition_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/component_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/component_parameters_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/circular_buffer_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/checkpoint_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/change_observer_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/asset_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/asset_hash_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/asset_buffer_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/agent_device_test.cpp | Formatting/signature spacing normalization in tests |
| test_package/adapter_test.cpp | Formatting/signature spacing normalization in tests |
| src/mtconnect/validation/observations.hpp | Comment/indentation spacing normalization |
| src/mtconnect/source/source.cpp | Signature spacing normalization |
| src/mtconnect/source/loopback_source.hpp | Signature spacing normalization |
| src/mtconnect/source/loopback_source.cpp | Signature spacing normalization |
| src/mtconnect/source/error_code.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/shdr/shdr_pipeline.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/shdr/shdr_pipeline.cpp | Signature spacing normalization |
| src/mtconnect/source/adapter/shdr/shdr_adapter.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/shdr/shdr_adapter.cpp | Signature spacing normalization |
| src/mtconnect/source/adapter/shdr/connector.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/shdr/connector.cpp | Signature spacing normalization |
| src/mtconnect/source/adapter/mqtt/mqtt_adapter.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/mqtt/mqtt_adapter.cpp | Signature spacing normalization |
| src/mtconnect/source/adapter/agent_adapter/session.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/agent_adapter/https_session.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/agent_adapter/http_session.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/agent_adapter/agent_adapter.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/agent_adapter/agent_adapter.cpp | Signature spacing normalization |
| src/mtconnect/source/adapter/adapter.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/adapter_pipeline.hpp | Signature spacing normalization |
| src/mtconnect/source/adapter/adapter_pipeline.cpp | Signature spacing normalization |
| src/mtconnect/sink/sink.cpp | Signature spacing normalization |
| src/mtconnect/sink/rest_sink/tls_dector.hpp | Signature spacing normalization |
| src/mtconnect/sink/rest_sink/session.hpp | Signature spacing normalization |
| src/mtconnect/sink/rest_sink/response.hpp | Signature spacing normalization |
| src/mtconnect/sink/rest_sink/request.hpp | Signature spacing normalization |
| src/mtconnect/sink/rest_sink/parameter.hpp | Signature spacing normalization |
| src/mtconnect/sink/rest_sink/cached_file.hpp | Signature spacing normalization |
| src/mtconnect/sink/mqtt_sink/mqtt_service.hpp | Signature spacing normalization + namespace comment alignment |
| src/mtconnect/sink/mqtt_entity_sink/mqtt_entity_sink.hpp | Namespace comment alignment |
| src/mtconnect/sink/mqtt_entity_sink/mqtt_entity_sink.cpp | Namespace comment alignment |
| src/mtconnect/ruby/ruby_vm.hpp | Signature spacing normalization |
| src/mtconnect/ruby/ruby_type.hpp | Signature spacing normalization |
| src/mtconnect/ruby/embedded.hpp | Signature spacing normalization |
| src/mtconnect/ruby/embedded.cpp | Signature spacing normalization |
| src/mtconnect/printer/printer.hpp | Signature spacing normalization |
| src/mtconnect/printer/json_printer.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/validator.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/upcase_value.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/topic_mapper.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/timestamp_extractor.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/shdr_tokenizer.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/shdr_token_mapper.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/response_document.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/pipeline_contract.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/pipeline_context.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/period_filter.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/mtconnect_xml_transform.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/message_mapper.hpp | Adds explicit include for adapter handler dependency |
| src/mtconnect/pipeline/json_mapper.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/duplicate_filter.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/delta_filter.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/deliver.cpp | Lowers some log lines from info→debug |
| src/mtconnect/pipeline/correct_timestamp.hpp | Signature spacing normalization |
| src/mtconnect/pipeline/convert_sample.hpp | Signature spacing normalization |
| src/mtconnect/parser/xml_parser.hpp | Signature spacing normalization |
| src/mtconnect/parser/json_parser.hpp | Signature spacing normalization |
| src/mtconnect/parser/json_parser.cpp | Signature spacing normalization |
| src/mtconnect/observation/change_observer.cpp | Signature spacing normalization |
| src/mtconnect/mqtt/mqtt_server.hpp | Signature spacing normalization |
| src/mtconnect/mqtt/mqtt_client.hpp | Signature spacing normalization |
| src/mtconnect/entity/xml_printer.hpp | Signature spacing normalization |
| src/mtconnect/entity/xml_parser.hpp | Signature spacing normalization |
| src/mtconnect/entity/qname.hpp | Signature spacing normalization |
| src/mtconnect/entity/json_parser.hpp | Signature spacing normalization |
| src/mtconnect/device_model/reference.hpp | Signature spacing normalization |
| src/mtconnect/device_model/reference.cpp | Signature spacing normalization |
| src/mtconnect/device_model/device.cpp | Signature spacing normalization |
| src/mtconnect/device_model/data_item/unit_conversion.hpp | Signature spacing normalization |
| src/mtconnect/device_model/data_item/unit_conversion.cpp | Signature spacing normalization |
| src/mtconnect/device_model/data_item/relationships.hpp | Signature spacing normalization |
| src/mtconnect/device_model/data_item/definition.hpp | Signature spacing normalization |
| src/mtconnect/device_model/configuration/specifications.cpp | Namespace comment alignment |
| src/mtconnect/device_model/configuration/solid_model.cpp | Namespace comment alignment |
| src/mtconnect/device_model/configuration/sensor_configuration.cpp | Namespace comment alignment |
| src/mtconnect/device_model/configuration/relationships.cpp | Namespace comment alignment |
| src/mtconnect/device_model/configuration/motion.cpp | Namespace comment alignment |
| src/mtconnect/device_model/configuration/coordinate_systems.cpp | Namespace comment alignment |
| src/mtconnect/device_model/configuration/configuration.cpp | Namespace comment alignment |
| src/mtconnect/device_model/composition.hpp | Minor pointer spacing normalization |
| src/mtconnect/device_model/composition.cpp | Signature spacing normalization |
| src/mtconnect/device_model/component.cpp | Signature spacing normalization |
| src/mtconnect/device_model/agent_device.hpp | Signature spacing normalization |
| src/mtconnect/device_model/agent_device.cpp | Signature spacing normalization |
| src/mtconnect/configuration/service.hpp | Signature spacing normalization |
| src/mtconnect/configuration/parser.hpp | Signature spacing normalization |
| src/mtconnect/configuration/hook_manager.hpp | Signature spacing normalization |
| src/mtconnect/configuration/config_options.hpp | Adds MonitorResources config key constant |
| src/mtconnect/buffer/circular_buffer.hpp | Signature spacing normalization |
| src/mtconnect/asset/asset.cpp | Signature spacing normalization |
| conan/profiles/vs64shared | Adds tool requirements for newer CMake on VS shared profile |
| conan/profiles/vs64debug | Adds tool requirements for newer CMake on VS debug profile |
| conan/profiles/vs64 | Adds tool requirements for newer CMake on VS release profile |
| conan/profiles/vs32shared | Adds tool requirements for newer CMake on Win32 shared profile |
| conan/profiles/vs32debug | Adds tool requirements for newer CMake on Win32 debug profile |
| conan/profiles/vs32 | Adds tool requirements for newer CMake on Win32 release profile |
| conan/profiles/macos | Raises CMake tool requirement; removes pinned OS version setting |
| CMakeLists.txt | Bumps agent version numbers; removes hardcoded macOS deployment target |
Review details
- Files reviewed: 25/250 changed files
- Comments generated: 9
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
7
to
9
| [platform_tool_requires] | ||
| cmake/>3.26.0 | ||
| cmake/>4.0 | ||
|
|
Comment on lines
+11
to
+15
| [platform_tool_requires] | ||
| cmake/>4.3 | ||
|
|
||
| [replace_tool_requires] | ||
| cmake/*: cmake/>4.3 |
Comment on lines
+13
to
+17
| [platform_tool_requires] | ||
| cmake/>4.3 | ||
|
|
||
| [replace_tool_requires] | ||
| cmake/*: cmake/>4.3 |
Comment on lines
+11
to
+15
| [platform_tool_requires] | ||
| cmake/>4.3 | ||
|
|
||
| [replace_tool_requires] | ||
| cmake/*: cmake/>4.3 |
Comment on lines
+11
to
+15
| [platform_tool_requires] | ||
| cmake/>4.3 | ||
|
|
||
| [replace_tool_requires] | ||
| cmake/*: cmake/>4.3 |
Comment on lines
+11
to
+15
| [platform_tool_requires] | ||
| cmake/>4.3 | ||
|
|
||
| [replace_tool_requires] | ||
| cmake/*: cmake/>4.3 |
Comment on lines
+14
to
+18
| [platform_tool_requires] | ||
| cmake/>4.3 | ||
|
|
||
| [replace_tool_requires] | ||
| cmake/*: cmake/>4.3 |
Comment on lines
+428
to
430
| MqttAuthorization* mqttAuct = new MqttAuthorization(options); | ||
| MqttTopicPermission permission = mqttAuct->getPermissionsForClient("mqtt_tcp_client_cpp/topic1"); | ||
|
|
Comment on lines
28
to
+31
| // adapter_pipeline.hpp defines source::adapter::Handler, and message_mapper.hpp | ||
| // references bare `string`/`Handler`, so both must be visible before it is parsed. | ||
| #include "mtconnect/source/adapter/adapter_pipeline.hpp" | ||
| #include "mtconnect/pipeline/message_mapper.hpp" | ||
| #include "mtconnect/source/adapter/adapter_pipeline.hpp" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MonitorResources=yesin the configuration file.