Add hoverable placeholder menu for custom paths - #641
Merged
Merged
Conversation
Owner
|
Hi! Thanks for your PR. I like that this helps make the placeholders easier to discover. The only change I'd like to request is that I don't like how the menu opens on hover. I'd rather have it require a click like the other three-dot buttons, and then just insert at the end of the text field. I understand the hover lets us insert by cursor position, but the way the menu closes if you scroll too much and the way insertion interacts with highlighted text don't feel so good to me. |
Author
|
Changed to click to open popupmenu, and still could insert by cursor |
Owner
|
Thanks :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hoverable placeholder menu for convenient input placeholder when custom game save path