docs: update js examples to use ES module imports - #252
Open
shuuji3 wants to merge 2 commits into
Open
Conversation
shuuji3
commented
Jun 3, 2026
|
|
||
| ```js | ||
| > var orderedEmoji = require('unicode-emoji-json/data-ordered-emoji') | ||
| import orderedEmoji from 'unicode-emoji-json/data-ordered-emoji.json' with { type: 'json' } |
Author
There was a problem hiding this comment.
I had to add the .json postfix here to be able to resolve the JSON path since ES Modules doesn't implicitly tries various extensions.
If you'd like to keep the same non-.json resolution to ease migration, I think you could add a new exports property in unicode-emoji-json package like this:
"exports": {
"./data-ordered-emoji": "./data-ordered-emoji.json",
"./data-emoji-components": "./data-emoji-components.json",
"./data-by-group": "./data-by-group.json"
},
shuuji3
commented
Jun 3, 2026
| @@ -1,4 +1,4 @@ | |||
| # emojilib  [](https://www.npmjs.com/package/emojilib) [](https://github.com/feross/standard) | |||
| # emojilib [](https://github.com/muan/emojilib/actions/workflows/test.yml) [](https://www.npmjs.com/package/emojilib) [](https://github.com/feross/standard) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #225
Hello 🙂 Thanks for keeping maintaining helpful library. I've updated the js example to use the modern ES Modules.
I split the code and output parts separately because the interactive node env cannot use
import * from 'lib'syntax as is.Glad to hear feedback.