Merged
Conversation
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the cogito dependency to a newer version from February 14, 2026, and refactors the code in core/agent/agent.go to work with the updated library API.
Changes:
- Updated
github.com/mudler/cogitodependency from version0.8.2-0.20260206153401-a5346975d42bto0.8.2-0.20260214201734-da0d4ceb2b44 - Simplified code in
core/agent/agent.goby removing an intermediary LLM call and associated error handling - Updated
go.sumto reflect the new dependency version
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates the cogito dependency version to the latest build |
| go.sum | Adds checksums for the new cogito dependency version |
| core/agent/agent.go | Removes intermediary LLM call, simplifying the code to directly use fragment's last message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| result := a.cleanupLLMResponse(responseFragment.LastMessage().Content) | ||
| result := a.cleanupLLMResponse(fragment.LastMessage().Content) |
There was a problem hiding this comment.
The removed code included error handling for the a.llm.Ask() call. Now fragment.LastMessage() is called directly without checking if fragment has messages or handling potential nil/empty cases. This could cause a panic if fragment.Messages is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.