fix: issue #418 - check mcp client connections and re-init#419
Open
vugenti wants to merge 2 commits intomudler:mainfrom
Open
fix: issue #418 - check mcp client connections and re-init#419vugenti wants to merge 2 commits intomudler:mainfrom
vugenti wants to merge 2 commits intomudler:mainfrom
Conversation
mudler
reviewed
Feb 16, 2026
|
|
||
| mcpNeedsInit := false | ||
| for _, server := range a.mcpSessions { | ||
| err := server.Ping(a.context, &mcp.PingParams{}) |
Owner
There was a problem hiding this comment.
while I like this, can we make it restart only the sessions which are unresponsive? it sounds safer to re-start only the MCP session which doesn't reply to Pings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping the mcp servers before adding actions for processing. if the connection is failed, re-initialize mcp actions before processing.