Skip to content

Update actions/setup-java action to v5#304

Merged
mueller-ma merged 1 commit intomainfrom
renovate/actions-setup-java-5.x
Apr 1, 2026
Merged

Update actions/setup-java action to v5#304
mueller-ma merged 1 commit intomainfrom
renovate/actions-setup-java-5.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Apr 1, 2026

This PR contains the following updates:

Package Type Update Change
actions/setup-java action major v4v5

Release Notes

actions/setup-java (actions/setup-java)

v5

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the renovate label Apr 1, 2026
@mueller-ma mueller-ma merged commit e66c0c2 into main Apr 1, 2026
4 checks passed
@mueller-ma mueller-ma deleted the renovate/actions-setup-java-5.x branch April 1, 2026 18:42
@bri-tong
Copy link
Copy Markdown

bri-tong commented Apr 1, 2026

Code Review: Update actions/setup-java action to v5

Summary

This is a Renovate-generated PR that bumps actions/setup-java from v4 to v5 (a major version upgrade) across two GitHub Actions workflow files (build.yml and deploy-apk.yml). All CI checks passed and the change has been merged. The diff is minimal (2 lines changed across 2 files), but as a major version bump, it warrants a quick compatibility check.

Blocking Issues

None. The CI build jobs completed successfully, confirming the v5 action works with the current workflow configuration.

Non-blocking Suggestions

1. distribution: 'adopt' is deprecated — consider switching to temurin

  • Files: .github/workflows/build.yml (line 15), .github/workflows/deploy-apk.yml (line 19)
  • Current: distribution: 'adopt'
  • Issue: AdoptOpenJDK transitioned to Eclipse Adoptium (Temurin) back in 2021. The adopt distribution identifier has been deprecated in actions/setup-java since v3 in favor of temurin. While it still works today (CI passes), it may be removed in a future version and points to stale/unmaintained binaries.
  • Suggested fix:
    distribution: 'temurin'
    This would align with current best practices and ensure forward compatibility.

2. Renovate PR description lacks v5 release notes

The PR body only links to a compare view (v4...v5) with no actual changelog or breaking change details. For a major version bump, it would be valuable to review the actions/setup-java releases page to understand what changed and whether any new features or deprecations apply.

Questions / Clarifications

None — the change is straightforward and CI validates it works as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants