You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code Review: Update actions/setup-java action to v5
Summary
This is a Renovate-generated PR that bumps actions/setup-java from v4 to v5 (a major version upgrade) across two GitHub Actions workflow files (build.yml and deploy-apk.yml). All CI checks passed and the change has been merged. The diff is minimal (2 lines changed across 2 files), but as a major version bump, it warrants a quick compatibility check.
Blocking Issues
None. The CI build jobs completed successfully, confirming the v5 action works with the current workflow configuration.
Non-blocking Suggestions
1. distribution: 'adopt' is deprecated — consider switching to temurin
Issue: AdoptOpenJDK transitioned to Eclipse Adoptium (Temurin) back in 2021. The adopt distribution identifier has been deprecated in actions/setup-java since v3 in favor of temurin. While it still works today (CI passes), it may be removed in a future version and points to stale/unmaintained binaries.
Suggested fix:
distribution: 'temurin'
This would align with current best practices and ensure forward compatibility.
2. Renovate PR description lacks v5 release notes
The PR body only links to a compare view (v4...v5) with no actual changelog or breaking change details. For a major version bump, it would be valuable to review the actions/setup-java releases page to understand what changed and whether any new features or deprecations apply.
Questions / Clarifications
None — the change is straightforward and CI validates it works as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v4→v5Release Notes
actions/setup-java (actions/setup-java)
v5Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.