Avoid truncation for inputs close to limit#57
Open
bhavanki wants to merge 1 commit intomuesli:masterfrom
Open
Conversation
Previous truncation code always truncated and added a tail once the processed input width exceeded the limit minus the tail width. For example, the input "foobar" truncated to width 6 with a tail "." would come out as "fooba.". Now, when the rune scanning loop passes into the danger zone where truncation might be required, but before the truncation limit is breached, it buffers runes instead of writing them out. If the truncation limit is exceeded, then the tail is written as usual. If it ends up not exceeded, then the buffered runes are written out, avoiding unnecessary truncation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous truncation code always truncated and added a tail once the processed input width exceeded the limit minus the tail width. For example, the input "foobar" truncated to width 6 with a tail "." would come out as "fooba.".
Now, when the rune scanning loop passes into the danger zone where truncation might be required, but before the truncation limit is breached, it buffers runes instead of writing them out. If the truncation limit is exceeded, then the tail is written as usual. If it ends up not exceeded, then the buffered runes are written out, avoiding unnecessary truncation.