Add skip package, which performs the inverse of truncate.#75
Open
qualidafial wants to merge 1 commit intomuesli:masterfrom
Open
Add skip package, which performs the inverse of truncate.#75qualidafial wants to merge 1 commit intomuesli:masterfrom
qualidafial wants to merge 1 commit intomuesli:masterfrom
Conversation
* Add skip.Writer, skip.NewWriter, and skip.NewWriterPipe. * Add helper functions skip.String, skip.StringWithPrefix, skip.Bytes, and skip.BytesWithPrefix. * Add README section for both the truncate and skip packages.
I wish I had checked open PRs before putting my own version of this together for exactly the same reason last night! |
Author
|
@muesli Hi Christian! Would you mind reviewing this when you have a moment? I've tried to match this PR closely to the coding styles in Reflow's other packages, so hopefully it will be a straightforward review. Cheers! |
Author
|
Ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the
truncatepackage's "tail" parameter, theskippackage supports aprefixparameter which can be used to provide a visual indication of horizontal scrolling.The
skippackage is a crucial building block for supporting horizontal scrolling of a viewport, as well as UI compositing e.g. to overlay a modal dialog over the TUI behind it.I have a working prototype for TUI compositing using this package, and hope to contribute it to charmbracelet/lipgloss once I've cleaned it up some.