fix(e2e): stabilise shared runs and fix deletion fixture - #561
Merged
Conversation
- Run templated tests after the other shared packages and wait for their namespaces to terminate, avoiding contention while preserving the existing query assertion and timeout. - Capture sanitised namespace diagnostics before cleanup, and align the deletion fixture and naming documentation with the enforced 25-character cluster-name limit. Signed-off-by: Verónica López <veronica.lopez@supabase.io>
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR addresses two independent failures in the nightly compatibility suite rooted in our e2e tests: a deletion-test fixture whose 26-character cluster name exceeds the operator’s 25-character limit, and contention between shared E2E packages that causes the templated suite to time out waiting for a primary. It also corrects the discrepancies in the name limit docs and captures sanitised namespace diagnostics before failed-test cleanup.
Main changes
shared/templatedalone.Shard.status.podRolesfor better signal.Testing
Ran the e2e framework unit tests and vet with the
e2ebuild tag, compiled the deletion e2e package, and validated the workflow withactionlintand YAML parsing. Also rangit diff --checkand verified the complete shared-package selection matrix.