chore(pvc): change default multigrescluster pvc retain policy - #562
Merged
niconosenzo merged 2 commits intoAug 4, 2026
Merged
Conversation
niconosenzo
force-pushed
the
set-pvc-retain-policy-to-delete
branch
from
August 4, 2026 08:54
1ada03a to
b55a0ca
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
niconosenzo
force-pushed
the
set-pvc-retain-policy-to-delete
branch
from
August 4, 2026 09:47
b55a0ca to
4a2143a
Compare
This comment has been minimized.
This comment has been minimized.
niconosenzo
force-pushed
the
set-pvc-retain-policy-to-delete
branch
from
August 4, 2026 10:27
4a2143a to
532aeff
Compare
This comment has been minimized.
This comment has been minimized.
niconosenzo
force-pushed
the
set-pvc-retain-policy-to-delete
branch
from
August 4, 2026 10:50
532aeff to
2c18f5e
Compare
This comment has been minimized.
This comment has been minimized.
MultigresCluster now owns the volumes lifecycle policy, but the ownership is only honoured when the retain policy is set to "Delete". - data volumes are kept (orphaned) to a max set by pvcOrphanReplicasThreshold - topo volumes are deleted with the multigresCluster CR (note: they survive to a toposerver statefulset removal) Signed-off-by: Nicolas Nosenzo <niconosenzo@gmail.com>
niconosenzo
force-pushed
the
set-pvc-retain-policy-to-delete
branch
from
August 4, 2026 11:13
2c18f5e to
66d233f
Compare
This comment has been minimized.
This comment has been minimized.
niconosenzo
force-pushed
the
set-pvc-retain-policy-to-delete
branch
from
August 4, 2026 13:23
5f3e941 to
0ebc70d
Compare
Currently, whenDeleted cascade hits toposerver's StatefulSet, this change pin to Retain regardless of the cluster-level default. Signed-off-by: Nicolas Nosenzo <niconosenzo@gmail.com>
niconosenzo
force-pushed
the
set-pvc-retain-policy-to-delete
branch
from
August 4, 2026 13:24
0ebc70d to
8c30fbc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultigresCluster now owns the volumes lifecycle policy, but the ownership is only honoured when the retain policy is set to "Delete".