Skip to content

override dapp config chain id from network config#1590

Merged
stefangutica merged 2 commits intodevelopmentfrom
override-chain-id-dapp-config
Feb 26, 2026
Merged

override dapp config chain id from network config#1590
stefangutica merged 2 commits intodevelopmentfrom
override-chain-id-dapp-config

Conversation

@bogdan-rosianu
Copy link
Contributor

Reasoning

  • chain ID was static in the dapp config files

Proposed Changes

  • update it continuously via the values from the network config

How to test

  • localhost:3001/dapp/config should reflect network value, rather the configured one in the json file

@bogdan-rosianu bogdan-rosianu self-assigned this Feb 26, 2026
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

k6 load testing comparison.
Base Commit Hash: f60bfd9
Target Commit Hash: 6ae86f1

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Mex43.43144.4751.6256.1336.70880.1040.1842.57-15.50% ✅+509.21% 🔴-22.15% ✅-24.15% ✅
Blocks80.78290.4992.0697.6163.63778.8670.3373.71-21.23% ✅+168.12% 🔴-23.61% ✅-24.49% ✅
Nodes679.5412482.06144.82515.393713.8511928.4710684.3211927.76+446.53% 🔴-4.44% ✅+7277.58% 🔴+2214.32% 🔴
Tokens43.63695.5351.6056.2636.41236.3440.3242.90-16.56% ✅-66.02% ✅-21.85% ✅-23.74% ✅
Accounts88.97343.13111.95120.0468.75660.7179.8685.48-22.73% ✅+92.56% 🔴-28.67% ✅-28.80% ✅
Transactions88.233104.5198.92109.2568.72551.1978.6486.87-22.11% ✅-82.25% ✅-20.50% ✅-20.49% ✅
Pool43.53550.2051.5656.3236.34196.6940.2043.03-16.52% ✅-64.25% ✅-22.04% ✅-23.58% ✅
Test Run Duration60002.0960001.54

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@stefangutica stefangutica merged commit bb8b755 into development Feb 26, 2026
5 of 7 checks passed
@stefangutica stefangutica deleted the override-chain-id-dapp-config branch February 26, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants