feat(bandcamp_importer): query discography links on both page and TralbumData hostnames#922
Merged
Merged
Conversation
…lbumData hostnames Some Bandcamp artists and labels carry a different base URL in `TralbumData` than the page the user is actually on. That mismatch is often a leftover from when Bandcamp supported whitelabel/custom-domain shops: the discography may be browsed on a `*.bandcamp.com` URL while `TralbumData` still points at a separate shop hostname (e.g. `shop.hammockmusic.com`). Until now, discography MusicBrainz lookups were built from the TralbumData hostname alone. On those pages that meant we could miss existing MB links that editors had attached to the canonical Bandcamp URL—or to the old shop mirror—depending on which hostname was used in the database. Look up both hostnames when they differ, and only show one icon per MusicBrainz release when both URLs resolve to the same entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Bandcamp artists and labels carry a different base URL in
TralbumDatathan the page the user is actually on. That mismatch is often a leftover from when Bandcamp supported whitelabel/custom-domain shops: the discography may be browsed on a*.bandcamp.comURL whileTralbumDatastill points at a separate shop hostname (e.g.shop.hammockmusic.com).Until now, discography MusicBrainz lookups were built from the TralbumData hostname alone. On those pages that meant we could miss existing MB links that editors had attached to the canonical Bandcamp URL—or to the old shop mirror—depending on which hostname was used in the database.
Look up both hostnames when they differ, and only show one icon per MusicBrainz release when both URLs resolve to the same entry.
Example discography page: https://hammock.bandcamp.com/music