feat: add per-module max_rc for final link#18
Open
mgrossmann wants to merge 1 commit into
Open
Conversation
Previously mvslink hardcoded RC>4 as failure threshold. Now each [[link.module]] can specify max_rc (default: 0, strict). Modules that need to tolerate linker warnings set max_rc = 4 explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_rcfield to[[link.module]](default: 0, strict)mvslink.pyusesmod.max_rcinstead of hardcodedRC > 4max_rc = 4explicitlyPreviously all link modules silently accepted RC=4. Now the default is strict (RC=0), making unexpected warnings visible. This is a breaking change for projects that rely on RC=4 being silently accepted — they need to add
max_rc = 4to the affected[[link.module]]entries.Test plan
make linkon a project with default max_rc (RC>0 → failure)make linkon a project withmax_rc = 4(RC≤4 → success)