Fix for thrown errors never invoking complete #2
Open
johntimothybailey wants to merge 2 commits intomxriverlynn:masterfrom
Open
Fix for thrown errors never invoking complete #2johntimothybailey wants to merge 2 commits intomxriverlynn:masterfrom
johntimothybailey wants to merge 2 commits intomxriverlynn:masterfrom
Conversation
…lve the complete (invoke complete). This solves an issue where a thrown error will never trigger the complete function.
…o the block function. This allows the developer to reference the spec within the block. With the Jasmine it function, the block supplied gets the context of spec (or rather is the context of spec)
|
I ran into the same issue. Please merge this pull request :) block.call(this,complete);fixes the problem. |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In default Jasmine, when an error is thrown within a it() the tests will continue forward.
If an error occurs within the block function provided, then the complete function is never invoked and thus the tests will not move forward until the timeout is triggered (default: 2000). Let me know if you guys need a sample. This solved our issues with several hundred tests taking "forever" on failures.