fix: stripe connect taxId, vatId

[TejaswiniT167]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates

Description

Additional Changes

• This PR modifies the database schema (database migration added)
• This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

• I formatted the code and addressed linter errors ./dev/format-all-files.sh
• I reviewed submitted code
• I added unit tests for my changes where possible
• I added a CHANGELOG entry if applicable

Summary by CodeRabbit

Release Notes

• New Features
  • Added optional VAT ID field for company payment account configuration to support enhanced company detail requirements.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 381eae95-66d7-4979-ae07-2e8cbf7820de

📥 Commits

Reviewing files that changed from the base of the PR and between 1aa00c4 and a289a52.

📒 Files selected for processing (3)

• lib/mobility-core/src/Kernel/External/Payment/Interface/Stripe.hs
• lib/mobility-core/src/Kernel/External/Payment/Interface/Types.hs
• lib/mobility-core/src/Kernel/External/Payment/Stripe/Types/Accounts.hs

---

Walkthrough

The PR extends the payment module to support VAT ID submission during company Stripe Connect account creation. A new optional vatId field is added to the public contract, propagated through the Stripe implementation type, serialized into form requests, and wired into the account creation flow.

Changes

VAT ID field propagation through payment integration

Layer / File(s)	Summary
Public contract: CompanyConnectDetails VAT field lib/mobility-core/src/Kernel/External/Payment/Interface/Types.hs	CompanyConnectDetails adds an optional vatId field with documentation comments alongside the existing taxId field.
Stripe type definition and form encoding lib/mobility-core/src/Kernel/External/Payment/Stripe/Types/Accounts.hs	CompanyDetails record gains a vat_id field, and the companyToForm function emits company[vat_id] form parameter when the value is present.
Integration: public to Stripe field mapping lib/mobility-core/src/Kernel/External/Payment/Interface/Stripe.hs	The createConnectAccount function maps the public CompanyConnectDetails.vatId into the Stripe CompanyDetails.vat_id during account request construction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A bunny hops through payment flows,
Where VAT IDs now formally go,
From contract to Stripe they hop and bound,
Each field aligned, each form resound! 🐰💳✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly indicates the PR addresses Stripe Connect integration, specifically adding support for both taxId and vatId fields across multiple type definitions and their implementations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-stripe-tax-id

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}