Hub asserts when out of buffers


*F´ Version*
*Affected Component*

Problem Description

See

fprime/Svc/GenericHub/GenericHub.cpp

Lines 35 to 39 in fd0ef09

    
           Fw::Buffer outgoing = allocate_out(0, static_cast<U32>(size + sizeof(U32) + sizeof(U32) + sizeof(FwBuffSizeType))); 
        
           auto serialize = outgoing.getSerializer(); 
        
           // Write data to our buffer 
        
           status = serialize.serializeFrom(static_cast<U32>(type)); 
        
           FW_ASSERT(status == Fw::FW_SERIALIZE_OK, static_cast<FwAssertArgType>(status));

If the Hub's buffer manager ever runs out of buffers, the Hub immediately asserts. Is this desired? Opening this to discuss at CCB

CCB: don't assert, add event and counter

The difficulty is that in a deployment where the hub is the event/telemetry sink (event connections instance hub), the hub's own failure event re-enters eventIn which means an unbounded recursion, which seems worse than the original assert. Some options:

Throttled event + counter emitted from a new run: Svc.Sched port
Throttled event only, carrying the running error count as an argument - but the count stops being observable once the throttle kicks in.

I'm not a huge fan of adding event/telemetry and the hassle this introduces (see #6166 (comment)). I wonder if it'd be better to just silently drop, return a status code where possible (on cmdRespOut for commands), and count of the BufferManager to report telemetry on number of packet dropped (== num of allocation failures). It's less featureful, but gets rid of the added complexity that JPL-Devin#278 introduces. Although it's really not that much complexity...

Svc/GenericHub: drop message with event and counter on allocation fai…

Navigation Menu

Repository navigation

Hub asserts when out of buffers #6166

Problem Description

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	Fw::Buffer outgoing = allocate_out(0, static_cast<U32>(size + sizeof(U32) + sizeof(U32) + sizeof(FwBuffSizeType)));
	auto serialize = outgoing.getSerializer();
	// Write data to our buffer
	status = serialize.serializeFrom(static_cast<U32>(type));
	FW_ASSERT(status == Fw::FW_SERIALIZE_OK, static_cast<FwAssertArgType>(status));

Hub asserts when out of buffers #6166

Description

Problem Description

Activity

thomas-bc commented on Oct 9, 2026

thomas-bc commented on Oct 11, 2026

thomas-bc commented on Oct 21, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions