Repository navigation
Backport fixes to telemetry, fd/memory leaks, bounds and status returns (#5563) - #5646
Merged
LeStarch merged 1 commit intoAug 12, 2026
Merged
Conversation
…ns (nasa#5563) * Backport nasa#5563 to v3.6.x * Resolves Darwin/Cpu.cpp leak of kernel-allocated buffer returned by host_processor_info() Co-authored-by: lestarch-autobot <lestarch+autobot@gmail.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: michael.d.starch <michael.d.starch@jpl.nasa.gov>
nathancheek
force-pushed
the
memory-leak-fix
branch
from
August 11, 2026 23:22
1892307 to
50fbd40
Compare
LeStarch
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
I have been noticing that an fprime deployment running on macOS slowly builds up memory usage. This was tracked down to
Svc::SystemResources's call toOs::Cpu::getTicks(), triggered viaSvc::SystemResources::run_handler()on a rate group.Fortunately, this was just fixed upstream with the addition of
cpu_data_release()inOs/Darwin/Cpu.cpp, but we would like the fix in v3.6. I went ahead and backported other* changes from #5563 since they seemed all good and relevant to v3.6.[*] All changes were backported except for changes to
Fw/DataStructuresandSvc/ActivePhaserwhich don't exist in v3.6Rationale
Svc::SystemResourcesshouldn't leak memory.Testing/Review Recommendations
Testing now with my project's deployment... will report back if any issues.
Future Work
N/A
AI Usage (see policy)
Claude helped me utilize lldb to find the leaky thread (a rate group). Once I told it Svc::SystemResources or something downstream was the culprit, it immediately identified the bug, as well as the recent patch. AI was not used for code generation or backporting.