Skip to content

Drv/Ip: correct SDD and doc comments to match shutdown/close semantics - #5688

Merged
LeStarch merged 2 commits into
nasa:develfrom
nathancheek:devel
Aug 17, 2026
Merged

LeStarch merged 2 commits into
nasa:develfrom
nathancheek:devel

Conversation

@nathancheek

Copy link
Copy Markdown
Contributor
Related Issue(s) n
Has Unit Tests (y/n) n
Documentation Included (y/n) y
Generative AI was used in this contribution (y/n) y

Change Description

Updates Drv/Ip documentation which had gotten out of sync with the implementation over time. These inconsistencies were identified while working on #5687.

Rationale

Documentation needs to match the implementation.

Testing/Review Recommendations

Future Work

AI Usage (see policy)

Claude helped port over the documentation changes made for v3.6 in #5687, many of which apply here.

thomas-bc
thomas-bc previously approved these changes Aug 14, 2026
LeStarch
LeStarch previously approved these changes Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report — base devel

Overall (line): 83.56% → 83.55% (-0.01)
Regression threshold: 0.50% (line).

Regressions

(none over threshold)

Modules changed

Module Line Δ Function Δ Branch Δ
Os/Generic/Types 92.50 +0.36 92.86 +0.00 75.70 +1.87

Modules without UTs

CFDP/Checksum/GTest, Drv/LinuxGpioDriver, Drv/LinuxI2cDriver, Drv/LinuxSpiDriver, Drv/LinuxUartDriver, Drv/Ports/DataTypes, FppTestProject/FppTest/topology/async, FppTestProject/FppTest/topology/components/Comp, FppTestProject/FppTest/topology/components/Framework, FppTestProject/FppTest/topology/components/Receiver, FppTestProject/FppTest/topology/components/Sender, FppTestProject/FppTest/topology/guarded, FppTestProject/FppTest/topology/sync, FppTestProject/FppTest/topology/top_ports, FppTestProject/FppTest/topology/types, Fw/Com, Fw/Comp, Fw/FilePacket/GTest, Fw/Fpy, Fw/Obj, Fw/Port, Fw/Prm, Fw/Sm, Fw/Test, Fw/Types/GTest, Os/Models, Svc/Ccsds/Types, Svc/FatalHandler, Svc/Subtopologies/CdhCore, Svc/Subtopologies/ComCcsds, Svc/Subtopologies/ComCcsdsSdls, Svc/Subtopologies/ComFprime, Svc/Subtopologies/ComLoggerTee, Svc/Subtopologies/DataProducts, Svc/Subtopologies/DpCompression, Svc/Subtopologies/FileHandling, Svc/Subtopologies/FileHandlingCfdp, Svc/Subtopologies/FileHandlingCfdp/FileHandlingCfdpConfig, TestDeploymentsProject/Ref/DpDemo, TestDeploymentsProject/Ref/PingReceiver, TestDeploymentsProject/Ref/RecvBuffApp, TestDeploymentsProject/Ref/SendBuffApp, TestDeploymentsProject/Ref/Top, TestDeploymentsProject/Ref/TypeDemo, cmake/test/data/TestConfigDeployment, cmake/test/data/TestDeployment/TestBuildAutocoder, cmake/test/data/TestDeployment/TestHeaderAutocoder, cmake/test/data/TestDeployment/TestLinkDepends, cmake/test/data/TestDeployment/TestRelative, cmake/test/data/test-fprime-library/TestLibrary/TestComponent, cmake/test/data/test-fprime-library2/TestLibrary2/TestComponent

@nathancheek
nathancheek dismissed stale reviews from LeStarch and thomas-bc via b18078f August 14, 2026 16:32
@LeStarch
LeStarch merged commit a107cda into nasa:devel Aug 17, 2026
69 of 72 checks passed
github-actions Bot added a commit that referenced this pull request Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants