Repository navigation
Set the socket UT receive timeout to 50 ms - #6216
Merged
Merged
Conversation
thomas-bc
approved these changes
Oct 16, 2026
thomas-bc
left a comment
Collaborator
There was a problem hiding this comment.
Small and efficient, much appreciated. Thanks.
3 tasks done
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
|
I'm going to merge #6217 first and see if (1) the error shows up in devel CI and (2) this PR fixes it |
lestarch-autobot
self-requested a review
October 16, 2026 19:55
Collaborator
|
That fixed it ! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Increases the receive timeout that
force_recv_timeoutinDrv/Ip/test/ut/SocketTestHelper.cppsets from 50 us to 50 ms. The comment added with it in8b4e870082said 50 ms; #5705 reworded the comment to 50 us without changing the value.Rationale
With #5706's 10 ms polling waits, 50 us receive timeouts overflow the reconnect-test histories on macOS (#6211). Doubling those histories in #5724 was not enough; at 50 ms the measured runs record 20 to 36 entries of the 2000.
Testing/Review Recommendations
macOS (Apple M5):
Drv_TcpServer_ut_exe,Drv_Udp_ut_exe,Drv_TcpClient_ut_exe,Drv_Ip_Tcp_test,Drv_Ip_Udp_test: 20 of 20 runs pass for each, at normal priority and undertaskpolicy -c background. Unmodified devel: TcpServer and Udp abort in 20 of 20 under background.fprime-util check --all: 135 of 135 pass.clang-format --dry-run -Werrorandgit diff --checkpass.Linux (arm64 VM):
Drv_Udp_ut_exetakes about 0.5 s longer; the other four are unchanged.Expected, not measured with gcov:
Drv/TcpServerline coverage may drop from 64/74 to 63/74, becauseTcpServerComponentImpl.cpp:62(RECV_NO_DATA) was only reached through the incidental 50 us timeouts.Future Work
A deterministic RECV_NO_DATA test for TcpServer would cover that line again.
Contributor Checklist
AI Usage (see policy)
AGENTS.md).The change is AI-generated.