Skip to content

CI: run unit/integration tests on develop- and main-targeted PRs #355

Description

@danielfromearth

Summary

Pull requests that target develop (the workflow prescribed in CONTRIBUTING) do not run the unit or integration test suite in CI. Two problems in the PR test path:

  1. Trigger filter excludes develop. .github/workflows/pull-request-received.yml runs run_tests.yml only when the PR's base branch matches feature/** | issue/** | issues/**. PRs into develop (or main) never match, so no test job runs — only pre-commit.ci / Snyk / Read the Docs checks appear.
  2. Missing required secrets. run_tests.yml declares EARTHDATA_USERNAME and EARTHDATA_PASSWORD as required: true for workflow_call, but pull-request-received.yml passes only codecov_token. Even if the trigger fired, the reusable-workflow call would fail validation for the missing required secrets. (The release path, version-and-build.yml, passes all three correctly.)

Net effect: develop-targeted PRs get no automated pytest at all; only local runs validate them.

Proposed fix

  • pull-request-received.yml: add develop and main to the branches filter, and pass the Earthdata secrets through to run_tests.yml.
  • run_tests.yml: make the Earthdata secrets optional and gate the integration step on their presence, so PRs from forks (which have no secrets) still run the unit tests and simply skip integration, while same-repo PRs and the release path run the full suite.

Verification

  • Opening this PR against develop should itself trigger the test workflow (self-validating), since pull_request uses the head branch's workflow definition.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    github_actionsPull requests that update GitHub Actions code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions