INTERNAL: Fix expire time parameter type from int to long#1100
Open
f1v3-dev wants to merge 1 commit into
Open
Conversation
Collaborator
Author
하위 호환성 정리✅ 기존 코드 그대로 동작 // int 리터럴 → long 으로 자동 형변환
CollectionAttributes attr = new CollectionAttributes(60, null, null);
attr.setExpireTime(60);
attr.setExpireTime(3600L);// 1. getExpireTime() 반환값을 int/Integer에 담는 경우
// 반환 타입이 Integer → Long으로 변경됨
int exp = attr.getExpireTime(); // X
Integer exp = attr.getExpireTime(); // X
// 2. 생성자/setter에 null을 넘기는 경우
// 파라미터 타입이 Integer → long(primitive)으로 변경됨
CollectionAttributes attr = new CollectionAttributes(null, null, null); // X
attr.setExpireTime(null); // X |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
int→long으로 변경합니다.long)을 사용하여 기존int리터럴이 자동으로 변환됩니다.수정 파일
v2 API
v2/AsyncArcusCommandsIF.javaexp파라미터int→longv2/AsyncArcusCommands.javapublic API
collection/Attributes.javaInteger→LongsetExpireTime(Integer)→setExpireTime(long)getExpireTime()반환 타입Integer→Longcollection/CollectionAttributes.javaInteger expireTime→long expireTime내부
collection/CollectionCreate.javaInteger expTime→Long expTimecollection/{List,Set,Map,BTree}Create.javaInteger expTime→Long expTimeOperationFactory.java,ops/{Store,CAS,Mutator,Touch}Operation.javaexp파라미터int→longprotocol/ascii/AsciiOperationFactory.java및 관련 implexp파라미터int→longprotocol/binary/BinaryOperationFactory.java및 관련 implexp파라미터int→long(int)캐스트로 4바이트 유지