INTERNAL: Separate hash tree operations from collection state updates in map/set#977
Open
zhy2on wants to merge 3 commits into
Open
INTERNAL: Separate hash tree operations from collection state updates in map/set#977zhy2on wants to merge 3 commits into
zhy2on wants to merge 3 commits into
Conversation
- CLOG → ccnt → space accounting → elem status
- CLOG → ccnt → space accounting → elem status
…set}_elem_{link,unlink}
Collaborator
|
@zhy2on |
Collaborator
|
아래와 같이 예상하고 있는 데, 참고 바랍니다.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
hash_tree모듈 추출을 위한 사전 작업을 진행했습니다. zset은 하나의 elem을 btree와 hash tree 두 자료구조에 모두 연결하므로CLOG/ccnt/space accounting/elem status업데이트는 collection 단에서 한 번만 이뤄져야 합니다.향후 작업
do_htree_elem_link에 있는sticky overflow,overflowcheck를 collection 단의 작업(do_{map, set}_elem_link내부)으로 빼냅니다.htree_elem_link: 현재 root가 NULL일 시 외부에서 root node를 생성해준 후 htree_elem_link를 하고 있습니다. hash tree 모듈에서는 node 관련 작업을 hash tree 단에서 해주어야 하므로 노드를 새로 생성하는 로직을 내부로 통합합니다.htree_elem_unlink: unlink 후 node의 elem이 sparse해지면 par_node의 체인으로 흡수하는 로직을 통합합니다.