Skip to content

feat: Added new video file consts - #284

Merged
botond-szabo merged 3 commits into
mainfrom
new-constants
Jul 9, 2026
Merged

botond-szabo merged 3 commits into
mainfrom
new-constants

Conversation

@botond-szabo

@botond-szabo botond-szabo commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Style
    • Updated a configuration comment for clearer wording.

@changeset-bot

changeset-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e0e433f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@botond-szabo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 52c1db6a-9dbd-4d47-b7a6-8fb6de36e808

📥 Commits

Reviewing files that changed from the base of the PR and between 444ee7c and e0e433f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • .github/workflows/danger.yml
  • packages/@necto/necto-constants/package.json
  • packages/@necto/necto-constants/src/index.ts
  • packages/@necto/necto-constants/src/video.ts
  • vite.config.ts
📝 Walkthrough

Walkthrough

This change updates a single inline comment in vite.config.ts, prefixing existing text with "Node:" within the lint ignore patterns configuration. No functional or logic changes were made.

Changes

Comment Update

Layer / File(s) Summary
Comment text edit
vite.config.ts
Inline comment in the lint.ignorePatterns block updated from "Will be removed once stable" to "Node: Will be removed once stable".

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title says new video file consts, but the PR only changes a comment in vite.config.ts. Rename the PR to reflect the actual change, e.g. update a Vite config comment.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch new-constants

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@necto-github-bot

necto-github-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
Fails
🚫

PR title doesn't follow conventional commits.

  • subject must not be sentence-case, start-case, pascal-case, upper-case
  • scope may not be empty

Since NodeKit squash-merges, the PR title becomes the commit message.
Examples:

  • feat(hooks): add usePress
  • fix(popper): correct arrow offset on flip
  • chore(deps): bump vitest

Generated by 🚫 dangerJS against e0e433f

@botond-szabo
botond-szabo enabled auto-merge July 9, 2026 17:21
@botond-szabo
botond-szabo added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit d509c8b Jul 9, 2026
6 of 7 checks passed
@botond-szabo
botond-szabo deleted the new-constants branch July 9, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant