Control time kept#663
Open
bjkomer wants to merge 2 commits into
Open
Conversation
|
|
||
| /** update the time axis display */ | ||
| this.axis_g | ||
| .call(this.axis); |
Collaborator
There was a problem hiding this comment.
This is a bit silly to have on two lines.
Seanny123
force-pushed
the
control-time-kept
branch
from
be7ec75 to
0991df0
Compare
Collaborator
|
@tcstewar this feature is ready for review now that it's been brought up to date with master |
Contributor
|
The kept_time value doesn't seem to persist. If I change the kept_time parameter and then reload the page, it goes back to the old 4s value. However, the config menu still has the changed value..... |
| sim.time_slider.update_kept_time(val); | ||
| } | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Why is this in Nego.NetGraph? It isn't used by any of the NetGraph components...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the time kept on the time slider to be configurable and saved to the config. Addresses #643