chore: remove unnecessary noqa E402 from shim modules (#771)#772
Open
chore: remove unnecessary noqa E402 from shim modules (#771)#772
Conversation
Move warnings.warn() after imports — the deprecation warning fires at import time regardless of ordering within the module. This eliminates the need for noqa E402 suppressions on the internal imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warnings.warn()after imports in both shim modules (nac_test/pabot.py,nac_test/robot_writer.py)# noqa: E402suppressions that were only needed due to the previous orderingThe deprecation warning fires at import time regardless of where it appears in the module — no functional change.
Closes
Type of Change
Testing Done
Checklist
pre-commit run -apasses)