Skip to content

Fix typo in PeerExpirationToggle component#665

Open
bomkz wants to merge 1 commit into
netbirdio:mainfrom
bomkz:patch-1
Open

Fix typo in PeerExpirationToggle component#665
bomkz wants to merge 1 commit into
netbirdio:mainfrom
bomkz:patch-1

Conversation

@bomkz

@bomkz bomkz commented Jun 11, 2026

Copy link
Copy Markdown

Issue ticket number and link

N/A

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • [ -] Documentation is not needed for this change (explain why)
    Simple Typo Fix

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • Bug Fixes
    • Corrected tooltip text grammar for peer settings configured via setup-key.

@CLAassistant

CLAassistant commented Jun 11, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR corrects a single grammar error in a tooltip message displayed in the peer configuration UI. The phrase "an setup-key" is changed to "a setup-key" on line 59 of PeerExpirationToggle.tsx. No functional behavior or component logic is altered.

Changes

Tooltip Text Fix

Layer / File(s) Summary
Setup-key tooltip article correction
src/modules/peer/PeerExpirationToggle.tsx
Tooltip message for disabled peer expiration toggles corrects article usage from "an setup-key" to "a setup-key".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A tiny hop, an article fix—
"An" becomes "a" in our grammar mix!
No logic harmed, just polish so bright,
One small word makes the tooltip right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: fixing a typo in the PeerExpirationToggle component.
Description check ✅ Passed The description follows the required template structure with issue ticket, documentation selection, and explanation. However, there is a syntax error in the checkbox marking ("- -]" instead of proper checkbox format), but the intent is clear.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/modules/peer/PeerExpirationToggle.tsx

Oops! Something went wrong! :(

ESLint: 9.39.2

TypeError: Converting circular structure to JSON
--> starting at object with constructor 'Object'
| property 'configs' -> object with constructor 'Object'
| property 'flat' -> object with constructor 'Object'
| ...
| property 'plugins' -> object with constructor 'Object'
--- property 'react' closes the circle
Referenced from: /.eslintrc.json
at JSON.stringify ()
at /node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2255:45
at Array.map ()
at ConfigValidator.formatErrors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2246:23)
at ConfigValidator.validateConfigSchema (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2277:84)
at ConfigArrayFactory._normalizeConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3123:19)
at ConfigArrayFactory._loadConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3088:21)
at ConfigArrayFactory._loadExtendedShareableConfig (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3393:21)
at ConfigArrayFactory._loadExtends (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3261:25)
at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3199:25)
(node:2) ESLintRCWarning: You are using an eslintrc configuration file, which is deprecated and support will be removed in v10.0.0. Please migrate to an eslint.config.js file. See https://eslint.org/docs/latest/use/configure/migration-guide for details. An eslintrc configuration file is used because you have the ESLINT_USE_FLAT_CONFIG environment variable set to false. If you want to use an eslint.config.js file, remove the environment variable. If you want to find the location of the eslintrc configuration file, use the --debug flag.
(Use node --trace-warnings ... to show where the warning was created)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/modules/peer/PeerExpirationToggle.tsx`:
- Line 59: In PeerActionCell.tsx update the grammar in the UI string at the
location referenced (around the PeerActionCell component / JSX render where the
tooltip/label reads "added with an setup-key") to use "a setup-key" instead;
search for the string "an setup-key" in the PeerActionCell render/JSX and
replace it with "a setup-key" so the displayed text is grammatically correct.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9b0865c-ec08-4c34-9de9-8b6b0850eb1c

📥 Commits

Reviewing files that changed from the base of the PR and between 1d8d32d and 3ed7fac.

📒 Files selected for processing (1)
  • src/modules/peer/PeerExpirationToggle.tsx

<IconInfoCircle size={14} />
<span>
This setting is disabled for all peers added with an setup-key.
This setting is disabled for all peers added with a setup-key.

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find all occurrences of "an setup-key" in the codebase to ensure consistency.

rg -n "an setup-key" --type=tsx --type=ts

Repository: netbirdio/dashboard

Length of output: 91


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find all occurrences of the exact typo in TS/TSX files.
rg -n "an setup-key" -S --glob='*.ts' --glob='*.tsx'

Repository: netbirdio/dashboard

Length of output: 184


Fix grammar typo in PeerActionCell.tsx (“an setup-key” → “a setup-key”)

src/modules/peers/PeerActionCell.tsx line 185 contains: “...added with an setup-key.” Change it to “...added with a setup-key.” (No other occurrences of “an setup-key” were found in TS/TSX.)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/modules/peer/PeerExpirationToggle.tsx` at line 59, In PeerActionCell.tsx
update the grammar in the UI string at the location referenced (around the
PeerActionCell component / JSX render where the tooltip/label reads "added with
an setup-key") to use "a setup-key" instead; search for the string "an
setup-key" in the PeerActionCell render/JSX and replace it with "a setup-key" so
the displayed text is grammatically correct.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bomkz could you please also update the typo in PeerActionCell.tsx too?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

<IconInfoCircle size={14} />
<span>
This setting is disabled for all peers added with an setup-key.
This setting is disabled for all peers added with a setup-key.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bomkz could you please also update the typo in PeerActionCell.tsx too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants