Implement std/os package for env/process/fs primitives#1041
Merged
Conversation
50d9b69 to
9812697
Compare
9812697 to
012321c
Compare
emil14
commented
Feb 25, 2026
This was referenced Mar 7, 2026
emil14
commented
Jun 18, 2026
emil14
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review Summary
Critical Issues (Blocking)
internal/runtime/funcs/os_helpers.go:191:runBinaryLoopreceives fromfirstInbefore it starts waiting onsecondIn. That changes the dataflow/backpressure semantics for every new two-inputstd/oscomponent using this helper (Setenv,Mkdir,MkdirAll,Rename,Truncate,MkdirTemp,CreateTemp): if the second input is produced first, or if producing the first input depends on the second branch being drained, the component can deadlock even though both inputs would eventually be available. Existing binary runtime funcs usereceive2(ctx, firstIn, secondIn)to arm both receives concurrently. Please switchrunBinaryLooptoreceive2and add a regression test that proves the second input can arrive before the first without blocking.
emil14
commented
Jun 27, 2026
emil14
commented
Jun 27, 2026
emil14
commented
Jun 27, 2026
emil14
commented
Jun 27, 2026
emil14
commented
Jun 27, 2026
emil14
commented
Jun 27, 2026
emil14
commented
Jun 27, 2026
emil14
commented
Jun 27, 2026
emil14
commented
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std/osfromArgs/Environto a practical typed surface for environment, process, filesystem, and temp-path operations#externbindings and register them ininternal/runtime/funcs/registry.goargsruntime function list construction bug (pre-sized slice + append)std/osDesign notes
sig) to avoid autonomous sendersValidation
golangci-lint run ./internal/runtime/funcs/... ./e2e/os_package/...go test ./internal/runtime/funcs/... ./e2e/os_packagegolangci-lint run ./...go test ./...(broad run started and progressed through many e2e packages; targeted changed-package suites fully passed)Part of #1033
Closes #586