Declarative UI #16111
Open
Declarative UI #16111
+1,855
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tobiasKaminsky
commented
Dec 10, 2025
tobiasKaminsky
commented
- Tests written, or not not needed
2 tasks
tobiasKaminsky
force-pushed
the
declarative-ui
branch
from
408d317 to
15356f0
Compare
alperozturk96
requested changes
Dec 10, 2025
app/src/main/java/com/nextcloud/ui/composeActivity/ComposeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/ui/composeActivity/ComposeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/ui/composeActivity/ComposeDestination.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/ui/fileactions/FileActionsBottomSheet.kt
Outdated
Show resolved
Hide resolved
alperozturk96
requested changes
Dec 17, 2025
app/src/main/java/com/nextcloud/ui/composeActivity/ComposeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/ui/composeActivity/ComposeActivity.kt
Outdated
Show resolved
Hide resolved
alperozturk96
force-pushed
the
declarative-ui
branch
4 times, most recently
from
c7b33c4 to
e6accfe
Compare
Signed-off-by: tobiasKaminsky <[email protected]> wip Signed-off-by: tobiasKaminsky <[email protected]> wip Signed-off-by: tobiasKaminsky <[email protected]> wip Signed-off-by: tobiasKaminsky <[email protected]> wip Signed-off-by: tobiasKaminsky <[email protected]> wip Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]> # Conflicts: # gradle/libs.versions.toml
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
declarative-ui
branch
from
139f569 to
999c848
Compare
alperozturk96
requested changes
Dec 19, 2025
| } | ||
|
|
||
| RemoteOperationResult result = new GetCapabilitiesRemoteOperation(currentCapability).execute(client); | ||
| RemoteOperationResult result = new GetCapabilitiesRemoteOperation(null).execute(client); |
Collaborator
There was a problem hiding this comment.
GetCapabilitiesRemoteOperation → why this is taking null? and also currentCapability not used
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16111.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.