Skip to content

fix: use existing parent id for gallery search task #16148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
alperozturk96 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: use existing parent id for gallery search task #16148

alperozturk96 wants to merge 1 commit into from

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Dec 16, 2025 •
edited
Loading

  • Tests written, or not not needed

Issue

Helps: #16139. Please read the issue first.

How to reproduce?

  1. Have a large number of images in nested directories
  2. Perform a fresh installation of the app
  3. Open the Media tab
  4. Navigate back to All Files
  5. Observe the database using App Inspection: files that previously had a valid parent ID are set to 0 after visiting the Media tab

Fixes

Overwriting parent id value

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Dec 16, 2025

/backport to stable-3.35

alperozturk96
alperozturk96 commented Dec 16, 2025
View reviewed changes
app/src/main/java/com/owncloud/android/ui/asynctasks/GallerySearchTask.java
// initialize oc file from remote file
OCFile ocFile = FileStorageUtils.fillOCFile(remoteFile);

// since remote does not contains parent id information use existing file to prevent overriding parent id with 0
Copy link
Collaborator Author

@alperozturk96 alperozturk96 Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote file does not contains the parent id thus fix needs to be in client. @tobiasKaminsky What do you think?

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code258258
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4545
Security1818
Total483483

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16148.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 marked this pull request as draft December 17, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

2. developing backport-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96