Conversation
mgallien
left a comment
There was a problem hiding this comment.
@tobiasKaminsky
thanks
can you fix the DCO check ?
see https://github.com/nextcloud/desktop/pull/9622/checks?check_run_id=66942968543
also we want to use conventional commit messages, can you have a look ?
see https://github.com/nextcloud/desktop/actions/runs/23048340558/job/66942971883?pr=9622
aa835cd to
a4cca2d
Compare
|
Done ✔ I do not have the secrets for debian, thus I could not update them for GitHub Actions. |
|
Hm. Actually it fails: --> working on it |
e170a11 to
8f2fe2d
Compare
b1a7284 to
f0fddba
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
f0fddba to
f6064f3
Compare
|
@mgallien this works now. |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9622.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
❌ The last analysis has failed. |
they are being used there https://github.com/nextcloud/desktop/blob/master/admin/linux/debian/drone-build.sh#L45-L52 @ivaradi I guess from the CI point of view, we do not make use of them ? |
We actually do. They are needed to decode the keys for uploading the source packages to the PPA and the openSUSE build service. I think the current setup is such that the secrets are set for the master branch only, so that only builds performed on that are uploaded. |
No description provided.