Skip to content

Drone to GARM#9622

Open
tobiasKaminsky wants to merge 1 commit intomasterfrom
drone2garm
Open

Drone to GARM#9622
tobiasKaminsky wants to merge 1 commit intomasterfrom
drone2garm

Conversation

@tobiasKaminsky
Copy link
Member

No description provided.

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky
thanks
can you fix the DCO check ?
see https://github.com/nextcloud/desktop/pull/9622/checks?check_run_id=66942968543
also we want to use conventional commit messages, can you have a look ?
see https://github.com/nextcloud/desktop/actions/runs/23048340558/job/66942971883?pr=9622

@tobiasKaminsky tobiasKaminsky force-pushed the drone2garm branch 2 times, most recently from aa835cd to a4cca2d Compare March 16, 2026 07:34
@tobiasKaminsky
Copy link
Member Author

Done ✔

I do not have the secrets for debian, thus I could not update them for GitHub Actions.
(But it also seems to still build?)

@tobiasKaminsky tobiasKaminsky requested a review from mgallien March 16, 2026 07:36
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Mar 16, 2026

Hm. Actually it fails:

+ git fetch origin debian/dist/jammy/
fatal: invalid refspec 'debian/dist/jammy/'
Warning:  Debian build failed but this is a non-blocking CI event

--> working on it

@tobiasKaminsky tobiasKaminsky force-pushed the drone2garm branch 5 times, most recently from e170a11 to 8f2fe2d Compare March 16, 2026 08:17
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@tobiasKaminsky tobiasKaminsky force-pushed the drone2garm branch 4 times, most recently from b1a7284 to f0fddba Compare March 16, 2026 08:51
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

@mgallien this works now.
But I do not see if/where those secrets are being used.

@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9622.zip

Digest: sha256:fadb67a902a5ad58521bc00590dd77c7186a46ec97554d2547427d1299600a8c

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@mgallien
Copy link
Collaborator

@mgallien this works now. But I do not see if/where those secrets are being used.

they are being used there https://github.com/nextcloud/desktop/blob/master/admin/linux/debian/drone-build.sh#L45-L52

@ivaradi I guess from the CI point of view, we do not make use of them ?
I will wait for your feedback before merging the PR

@ivaradi
Copy link
Contributor

ivaradi commented Mar 17, 2026

@ivaradi I guess from the CI point of view, we do not make use of them ? I will wait for your feedback before merging the PR

We actually do. They are needed to decode the keys for uploading the source packages to the PPA and the openSUSE build service. I think the current setup is such that the secrets are set for the master branch only, so that only builds performed on that are uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants