Set folders writable if remote perms require it, recurse into subdirs if etag and remoteperms differ #9637
Open
Set folders writable if remote perms require it, recurse into subdirs if etag and remoteperms differ #9637
Conversation
…ssions Some of these should not mark the folder as read-only. Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
…odifiable permissions present Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
subfolders should also be updated Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
I'm still not sure if `serverEntry.remotePerm != dbEntry._remotePerm` was intentional, or if it's even necessary to check for that as well. The etag should change if permissions were changed, but this is not always the case (e.g. due to a fixed bug in a storage app). Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
Member
Author
|
/backport to stable-33.0 |
Member
Author
|
/backport to stable-4.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9637.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain remote permissions (CanWrite/CanDelete/CanRename/CanMove) allow contents of a certain folder to be changed. Setting those folders read-only just because the CanAddSubDirectories/CanAddFile permission seems to be the wrong thing to do.
I'm still not sure if
serverEntry.remotePerm != dbEntry._remotePermwas intentional, or if it's even necessary to check for that as well; the etag should change if permissions were changed, but this seems to not always be the case (e.g. due to a fixed bug in a storage app).