Move invite-accepted capability and implementation to contacts app. by redblom · Pull Request #57853 · nextcloud/server

redblom · 2026-01-27T15:43:01Z

Resolves: #

Summary

Code moved to contacts app, see nextcloud/contacts#4417

TODO

deal with inviteAcceptedDialog code

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

ChristophWurst · 2026-01-28T16:48:51Z

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

ArtificialOwl · 2026-01-28T17:23:59Z

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

This is done on my request:

it is moved out of server because the implementation of the feature creates its own db table and does not provide an API to manage it,
it will not break OCM, it will only not enable the 'invite-accepted' capability if contacts is not installed. the capability is useless without the contacts app,
contacts will register the capability and fully manage the db table

ArtificialOwl · 2026-01-28T17:26:18Z

let's ping @mickenordin on this one !

mickenordin · 2026-01-28T18:23:32Z

let's ping @mickenordin on this one !

I haven't reviewed the change, but in principal I see no problem with it.

redblom · 2026-01-30T09:27:35Z

Rebased, squashed, removed draft label.

github-actions · 2026-02-11T02:14:08Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

miaulalala · 2026-02-11T09:13:54Z

Hey @redblom , can you do the following things?

Fetch current master - git fetch origin (if your remote is not called origin, replace it with whatever your remote name is)
Squash your commits into a single one, and add a signoff
- The easiest way is using git reset --soft origin/master - this will reset your branch to master but leave all your changes as staged files so nothing is lost. It removes your commit history, but not your file changes.
Run composer cs:fix to autofix the PHP linting issues
Then you can do your usual git add (I like using git add -p to check my changes in chunks within a diff view, but you do you 😉 ) to stage your lint fixes
Use `git commit -sm "fix: your message here" to signoff your commit
push to your branch
Ping me and I'll enable the workflows

ETA: you can do the same workflow on the contacts branch too

redblom · 2026-02-17T10:47:21Z

* [ ]  Ping me and I'll enable the workflows

@miaulalala - ping !

miaulalala · 2026-02-17T11:02:41Z

Thanks for the ping!

A couple more steps and we should be good:

Please run composer openapi. Commit these changes with git add.
The signoff is not the expected one.
This should be fixable as instructed here https://docs.github.com/en/account-and-profile/how-tos/email-preferences/setting-your-commit-email-address.
If you're struggling with this point, let me know and we can work around it.
When fixed, run git commit --amend --signoff and push again.

miaulalala · 2026-02-17T13:32:53Z

@ArtificialOwl can you review? CI is fine now, only workflows not allowed on forks are red.

artonge · 2026-04-15T13:22:00Z

+		$table_name = 'federated_invites';
+
+		if ($schema->hasTable($table_name)) {
+			$schema->dropTable($table_name);


Do we have a repair step to move the data from the old to the new table?

Answer from the guided review was no, as this was not used.

I know what I said during the guided review but after some contemplation I now think it would be better to have a repair step to secure existing data. What would be the appropriate strategy?

https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/repair.html

In the other PR, I also emited the idea of keeping the table if the columns are the same. Might be easier.

In the other PR, I also emited the idea of keeping the table if the columns are the same. Might be easier.

I like that idea.

So what I understood from @nickvergessen the reason to drop the table is to not have a table when that is not used (by cloud_federation_app), which makes sense of course. However we never really discussed what to do with existing data.

I suppose we can do a conditional table drop, only drop when there is no data in the table. Recreating the table in the Contacts app is conditional anyway. That way we would secure existing data.
ps. columns are the same

In the other PR, I also emited the idea of keeping the table if the columns are the same. Might be easier.

I like that idea.

So what I understood from @nickvergessen the reason to drop the table is to not have a table when that is not used (by cloud_federation_app), which makes sense of course. However we never really discussed what to do with existing data.

I suppose we can do a conditional table drop, only drop when there is no data in the table. Recreating the table in the Contacts app is conditional anyway. That way we would secure existing data. ps. columns are the same

Makes sense

artonge · 2026-04-15T14:37:02Z

We need to document this here: https://github.com/nextcloud/documentation/blob/master/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_34.rst#added-apis-1

The idea is to backport to stable 33 once this is merged. So add to .../upgrade_to_33rst instead ?

Yes, but I am not sure that we'll backport that to 33 as this is not really critical.

miaulalala · 2026-04-23T11:29:41Z

can you run composer openapi and squash your commit history?

…ation. Signed-off-by: Antoon P <antoon.prins@surf.nl>

redblom requested a review from a team as a code owner January 27, 2026 15:43

redblom requested review from leftybournes, nfebe, salmart-dev and sorbaugh and removed request for a team January 27, 2026 15:43

redblom marked this pull request as draft January 27, 2026 15:43

AndyScherzinger requested a review from ChristophWurst January 27, 2026 22:30

ChristophWurst requested a review from ArtificialOwl January 28, 2026 16:48

redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 7cb53f3 to 2d2e4a1 Compare January 28, 2026 16:58

mickenordin force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 2d2e4a1 to aea3c70 Compare January 28, 2026 18:22

redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from aea3c70 to 254681c Compare January 30, 2026 09:26

redblom marked this pull request as ready for review January 30, 2026 10:12

redblom requested review from a team and nickvergessen as code owners January 30, 2026 10:12

nickvergessen requested changes Jan 30, 2026

View reviewed changes

Comment thread apps/cloud_federation_api/lib/Migration/Version1016Date202502262004.php

Comment thread lib/public/OCM/Events/LocalOCMDiscoveryEvent.php Outdated

redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 2 times, most recently from 3948b49 to 57769de Compare February 4, 2026 09:30

redblom requested a review from nickvergessen February 4, 2026 09:33

github-actions Bot added the feedback-requested label Feb 11, 2026

redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 2 times, most recently from 7f0ecf2 to ddfe68d Compare February 17, 2026 10:36

redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from ddfe68d to 9bae2c0 Compare February 17, 2026 12:27

redblom requested a review from provokateurin as a code owner February 17, 2026 12:27

artonge force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 9bae2c0 to 48ad12d Compare April 15, 2026 13:15

artonge added 3. to review Waiting for reviews feature: federation pending documentation This pull request needs an associated documentation update labels Apr 15, 2026

artonge reviewed Apr 15, 2026

View reviewed changes

redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 48ad12d to ea79d6a Compare April 22, 2026 14:19

DorraJaouad force-pushed the master branch from 7880bfa to 0172b1d Compare April 23, 2026 09:41

fix(ocm): Move out of server invite-accepted capability and implement…

e40b6fa

…ation. Signed-off-by: Antoon P <antoon.prins@surf.nl>

redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from ea79d6a to e40b6fa Compare April 23, 2026 13:04

Uh oh!

Conversation

redblom commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

ChristophWurst commented Jan 28, 2026

Uh oh!

ArtificialOwl commented Jan 28, 2026

Uh oh!

ArtificialOwl commented Jan 28, 2026

Uh oh!

mickenordin commented Jan 28, 2026

Uh oh!

redblom commented Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 11, 2026

Uh oh!

miaulalala commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

redblom commented Feb 17, 2026

Uh oh!

miaulalala commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miaulalala commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miaulalala commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

redblom commented Jan 27, 2026 •

edited

Loading

miaulalala commented Feb 11, 2026 •

edited

Loading

miaulalala commented Feb 17, 2026 •

edited

Loading

miaulalala commented Feb 17, 2026 •

edited

Loading