Skip to content

docs(CertificateManager/ICertificateManager): clarify API#60363

Open
joshtrichards wants to merge 2 commits into
masterfrom
jtr/docs-CertificateManager
Open

docs(CertificateManager/ICertificateManager): clarify API#60363
joshtrichards wants to merge 2 commits into
masterfrom
jtr/docs-CertificateManager

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

  • Resolves: #

Summary

This updates both CertificateManager and ICertificateManager to keep the concrete implementation and public contract aligned - and to fully document the OCP API.

Notes

Only functional change is making the CertificateManager::createCertificateBundle() helper private. It was already not part of the interface and is only used internally within the implementation itself.

TODO

  • Possibly make one more pass back through the implementation to drop some bits now better covered in the interface docs

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards changed the title docs(CertificateManager): clarify ICertificateManager/CertificateManager APIs/interface docs(CertificateManager): clarify ICertificateManager/CertificateManager API May 13, 2026
@joshtrichards joshtrichards changed the title docs(CertificateManager): clarify ICertificateManager/CertificateManager API docs(CertificateManager/ICertificateManager): clarify API May 13, 2026
@joshtrichards joshtrichards marked this pull request as ready for review May 13, 2026 18:47
@joshtrichards joshtrichards requested a review from a team as a code owner May 13, 2026 18:47
@joshtrichards joshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 13, 2026
@joshtrichards joshtrichards requested review from CarlSchwan, artonge, blizzz, icewind1991, leftybournes, provokateurin and salmart-dev and removed request for a team May 13, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant