Open
Conversation
heylf
reviewed
Mar 13, 2026
Collaborator
heylf
left a comment
There was a problem hiding this comment.
Looks at first glance fine. I will dig deeper now.
Member
|
As I'm talking to @priyalT on Zoom, I did a quick generic review:
|
Collaborator
|
Linter issue might fix itself if we merge PR #123 |
Adds the region_similarity QC module and updates the subworkflow and nextflow config to support dynamic module selection via params.segtraq_modules. Also updates test snapshots to reflect the config changes.
heylf
reviewed
Mar 13, 2026
|
|
||
| prefix = task.ext.prefix ?: "${meta.id}" | ||
|
|
||
| template('clustering_stability.py') |
Collaborator
There was a problem hiding this comment.
Just write template clustering_stability.py
Co-authored-by: heylf <flo.minion.info@gmail.com>
Co-authored-by: heylf <flo.minion.info@gmail.com>
heylf
approved these changes
Mar 13, 2026
Collaborator
heylf
left a comment
There was a problem hiding this comment.
LGTM.
Could be merged. Then probably it needs a bit honing and testing to see how it works with the pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).Description
Adds SegTraQ (Segmentation and Transcript Assignment QC) as a quality control module for spatial omics segmentation results.
What is SegTraQ?
A Python toolkit for quantitative and visual QC of segmentation and transcript assignment in spatial omics data, developed at EMBL.
Changes
New files:
Modified files:
run_segtraq,segtraq_centroid_x_key,segtraq_centroid_y_key