-
Notifications
You must be signed in to change notification settings - Fork 102
Set a limit on the number of access logs Agent can tail #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
==========================================
- Coverage 86.27% 85.32% -0.95%
==========================================
Files 102 102
Lines 12622 12984 +362
==========================================
+ Hits 10890 11079 +189
- Misses 1253 1418 +165
- Partials 479 487 +8
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
aphralG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update TestResolveConfig() to also check for MaxAccessLogFiles
Proposed changes
Limit the number of access logs that Agent tails by default in order to reduce overhead. The limit can be configured in the agent conf as seen in the following example:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)