Skip to content

Conversation

@sjberman
Copy link
Collaborator

Problem: Agent logs a correlation ID when it calls the control plane. The control plane doesn't log the ID, making it hard to cross-reference and debug the connections.

Solution: For relevant logs, add the correlation ID.

Closes #4297

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: Agent logs a correlation ID when it calls the control plane. The control plane doesn't log the ID, making it hard to cross-reference and debug the connections.

Solution: For relevant logs, add the correlation ID.
@sjberman sjberman requested a review from a team as a code owner December 22, 2025 16:25
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.29%. Comparing base (eb83cdb) to head (7476793).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/nginx/agent/file.go 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4506      +/-   ##
==========================================
- Coverage   86.31%   86.29%   -0.02%     
==========================================
  Files         132      132              
  Lines       14859    14874      +15     
  Branches       35       35              
==========================================
+ Hits        12825    12836      +11     
- Misses       1813     1816       +3     
- Partials      221      222       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman merged commit 0a9a95e into main Dec 23, 2025
75 of 79 checks passed
@sjberman sjberman deleted the chore/log-id branch December 23, 2025 14:50
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

No logging of "correlation_id" at default log level

5 participants