Introduced workarounds for technical debt 251 #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kosta Ilic <[email protected]>
Signed-off-by: Kosta Ilic <[email protected]>
KostaIlic2
changed the title
Signed-off-by: Kosta Ilic <[email protected]>
Signed-off-by: Kosta Ilic <[email protected]>
…hat made more sense. Signed-off-by: Kosta Ilic <[email protected]>
…ames. Signed-off-by: Kosta Ilic <[email protected]>
bkeryan
requested changes
Jan 14, 2026
Collaborator
There was a problem hiding this comment.
I don't think we need/want to run doctests through Sphinx. I assume you added this to enable the .. testsetup:: directive and that pytest supports it.
Contributor
Author
There was a problem hiding this comment.
@bkeryan, I suggest we look together at the root cause and a fix I'd like to propose for that before spending more time on this PR.
Collaborator
There was a problem hiding this comment.
Does this issue only affect run_unit_tests_oldest_deps.yml? If so, I think disabling doctests on the command line in that workflow file would be a less obtrusive workaround. If --no-doctest-modules doesn't work, try -p no:doctest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for incorrectly skipped documentation tests. Incorrect skipping is due to the issue described in #251
I commented out the lines that were causing the skipping, and introduced an alternative implementation that is not elegant but works.
So we don't lose test coverage due to a bug in a dependency.
What testing has been done?
I ran documentation tests with version of numpy that these tests should work with. Before the change I noticed 4 skipped tests, after the change there were no skipped tests.