Repository navigation
Match scroll containers by id, instead of by pointer - #659
Open
samloeschen wants to merge 1 commit into
Open
samloeschen wants to merge 1 commit into
samloeschen wants to merge 1 commit into
Conversation
…case where it was possible for an old container to point to memory now used by a new element, and write bounds/dimensions/etc into the wrong scroll record
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found a case where it was possible for an old element to accidentally match a new element because they occupied the same address. Because scroll state persists between frames Clay could then write bounds and content dimensions into the wrong scroll record.
I also fixed a decrement that seemed like it was missing in the scroll container data cleanup.