Enforce comprehensive conformance coverage

README.md

@@ -34,7 +34,7 @@ const payload = message({
 
 - `python/` — the established Python package.
 - `typescript/` — the ESM TypeScript package.
-- `spec/` — 79 valid fixtures, shared invalid cases, and limits.
+- `spec/` — 82 valid fixtures, shared invalid cases, capability coverage, and limits.
 - `docs/` — the Docusaurus documentation site.
 
 See the [documentation site](https://nicklambourne.github.io/slackblocks/) for installation and usage.

docs/docs/contributing.mdx

@@ -53,11 +53,12 @@ The Python and TypeScript conformance suites both exercise every ID in `spec/man
 
 ## Add or change a Block Kit feature
 
-1. Add or update canonical JSON in `spec/fixtures/valid/` and register it in `spec/manifest.json`.
-2. Add invalid behavior to `spec/fixtures/invalid/manifest.json` when the feature introduces a validation rule.
-3. Update `spec/limits.json` for shared scalar constraints.
-4. Implement the feature idiomatically in both packages, or record a reason in the affected skip list.
-5. Add language-native tests and update the relevant guide or executable example.
+1. Add or update canonical JSON in `spec/fixtures/valid/`, register it in `spec/manifest.json`, and link the exact official Slack reference used to validate it.
+2. Map every new JSON-producing capability to at least one valid fixture in `spec/coverage.json`.
+3. Add invalid behavior to `spec/fixtures/invalid/manifest.json` when the feature introduces a validation rule. Every scalar leaf in `spec/limits.json` must have a matching invalid case.
+4. Update `spec/limits.json` for shared scalar constraints.
+5. Implement the feature idiomatically in both packages, or record a reason in the affected skip list.
+6. Add language-native tests and update the relevant guide or executable example.
 
 When introducing a cross-language API, serialized JSON and validation outcomes are shared; public naming and construction style are language-native.
 

python/slackblocks/blocks.py

@@ -26,6 +26,7 @@
     EmailInput,
     ExternalMultiSelectMenu,
     ExternalSelectMenu,
+    FileInput,
     NumberInput,
     PlainTextInput,
     RadioButtonGroup,
@@ -85,6 +86,7 @@
     RichTextInput,
     EmailInput,
     URLInput,
+    FileInput,
 )
 
 

python/slackblocks/elements.py

@@ -404,11 +404,9 @@ def __init__(
         self.max_files = validate_int(max_files, min_value=1, max_value=10, allow_none=True)
 
     def _resolve(self) -> dict[str, Any]:
-        # FileInput currently does not emit the "type" attribute; this is
-        # preserved from prior behaviour. The pre-existing #154 export work
-        # surfaced this class but did not change its rendering contract.
         return resolve(
             {
+                **self._attributes(),
                 "action_id": self.action_id,
                 "filetypes": self.filetypes,
                 "max_files": self.max_files,

python/test/conformance/test_conformance.py

@@ -7,27 +7,35 @@
 import pytest
 
 from slackblocks import (
+    ActionsBlock,
     Button,
+    ConfirmationDialogue,
     ContextBlock,
     DividerBlock,
     FileInput,
     HeaderBlock,
     HomeTabView,
     Image,
+    ImageBlock,
     InputBlock,
     LengthError,
+    MarkdownBlock,
     MissingRequiredError,
+    ModalView,
     MutualExclusivityError,
     NumberInput,
     Option,
+    OptionGroup,
     OverflowMenu,
     PlainText,
+    PlainTextInput,
     RangeError,
     SectionBlock,
     SlackFile,
     StaticSelectMenu,
     Text,
     TypeMismatchError,
+    VideoBlock,
 )
 from slackblocks.errors import InvalidUsageError
 
@@ -50,10 +58,23 @@ def test_valid_manifest_covers_the_entire_fixture_corpus() -> None:
         for path in (SPEC_ROOT / "fixtures" / "valid").rglob("*.json")
     }
     assert manifest["spec_version"] == "1.0.0"
-    assert len(fixture_ids) == 79
+    assert fixture_ids
+    assert len(fixture_ids) == len(manifest["fixtures"])
     assert fixture_ids == files
 
 
+def test_every_shared_json_capability_has_an_official_fixture() -> None:
+    manifest = load_json(SPEC_ROOT / "manifest.json")
+    coverage = load_json(SPEC_ROOT / "coverage.json")
+    fixtures = {fixture["id"]: fixture for fixture in manifest["fixtures"]}
+    assert coverage["spec_version"] == manifest["spec_version"]
+    for capability, fixture_ids in coverage["capabilities"].items():
+        assert fixture_ids, capability
+        for fixture_id in fixture_ids:
+            assert fixture_id in fixtures, f"{capability} -> {fixture_id}"
+            assert fixtures[fixture_id]["slack_docs"].startswith("https://docs.slack.dev/")
+
+
 def test_every_valid_fixture_is_exercised_by_a_python_construction_test() -> None:
     manifest = load_json(SPEC_ROOT / "manifest.json")
     test_source = "\n".join(
@@ -78,18 +99,197 @@ def option(value: str = "a") -> Option:
     return Option(text=PlainText("A"), value=value)
 
 
+LIMITS = load_json(SPEC_ROOT / "limits.json")
+
+
+def video(**overrides: object) -> VideoBlock:
+    inputs: dict[str, object] = {
+        "alt_text": "Video",
+        "thumbnail_url": "https://example.com/thumbnail.png",
+        "title": "Title",
+        "video_url": "https://example.com/video.mp4",
+        **overrides,
+    }
+    return VideoBlock(**inputs)  # type: ignore[arg-type]
+
+
 INVALID_CASES: dict[str, Callable[[], object]] = {
     "text-empty": lambda: Text(""),
     "text-too-long": lambda: Text("x" * 3001),
+    "button-action-id-too-long": lambda: Button(
+        text="A", action_id="x" * (LIMITS["action_id"]["max_length"] + 1)
+    ),
+    "button-text-too-long": lambda: Button(
+        text="x" * (LIMITS["button"]["text"]["max_length"] + 1), action_id="a"
+    ),
+    "button-url-too-long": lambda: Button(
+        text="A",
+        action_id="a",
+        url="x" * (LIMITS["button"]["url"]["max_length"] + 1),
+    ),
+    "button-value-too-long": lambda: Button(
+        text="A",
+        action_id="a",
+        value="x" * (LIMITS["button"]["value"]["max_length"] + 1),
+    ),
+    "confirmation-title-too-long": lambda: ConfirmationDialogue(
+        title="x" * (LIMITS["confirmation"]["title"]["max_length"] + 1),
+        text="Text",
+        confirm="Yes",
+        deny="No",
+    ),
+    "confirmation-text-too-long": lambda: ConfirmationDialogue(
+        title="Title",
+        text="x" * (LIMITS["confirmation"]["text"]["max_length"] + 1),
+        confirm="Yes",
+        deny="No",
+    ),
+    "confirmation-confirm-too-long": lambda: ConfirmationDialogue(
+        title="Title",
+        text="Text",
+        confirm="x" * (LIMITS["confirmation"]["confirm"]["max_length"] + 1),
+        deny="No",
+    ),
+    "confirmation-deny-too-long": lambda: ConfirmationDialogue(
+        title="Title",
+        text="Text",
+        confirm="Yes",
+        deny="x" * (LIMITS["confirmation"]["deny"]["max_length"] + 1),
+    ),
+    "option-text-too-long": lambda: Option(
+        text="x" * (LIMITS["option"]["text"]["max_length"] + 1), value="a"
+    ),
+    "option-value-too-long": lambda: option("x" * (LIMITS["option"]["value"]["max_length"] + 1)),
+    "option-description-too-long": lambda: Option(
+        text="A",
+        value="a",
+        description="x" * (LIMITS["option"]["description"]["max_length"] + 1),
+    ),
+    "option-group-label-too-long": lambda: OptionGroup(
+        label="x" * (LIMITS["option_group"]["label"]["max_length"] + 1),
+        options=[option()],
+    ),
+    "option-group-empty": lambda: OptionGroup(label="Group", options=[]),
+    "option-group-too-many-options": lambda: OptionGroup(
+        label="Group",
+        options=[
+            option(str(index))
+            for index in range(LIMITS["option_group"]["options"]["max_items"] + 1)
+        ],
+    ),
+    "select-placeholder-too-long": lambda: StaticSelectMenu(
+        action_id="a",
+        options=[option()],
+        placeholder="x" * (LIMITS["select"]["placeholder"]["max_length"] + 1),
+    ),
+    "select-too-many-options": lambda: StaticSelectMenu(
+        action_id="a",
+        options=[
+            option(str(index)) for index in range(LIMITS["select"]["options"]["max_items"] + 1)
+        ],
+    ),
+    "select-too-many-option-groups": lambda: StaticSelectMenu(
+        action_id="a",
+        option_groups=[
+            OptionGroup(label=f"Group {index}", options=[option()])
+            for index in range(LIMITS["select"]["option_groups"]["max_items"] + 1)
+        ],
+    ),
+    "overflow-empty": lambda: OverflowMenu("a", []),
+    "overflow-too-many-options": lambda: OverflowMenu(
+        "a",
+        [option(str(index)) for index in range(LIMITS["overflow"]["options"]["max_items"] + 1)],
+    ),
+    "file-input-max-files-too-small": lambda: FileInput(
+        action_id="a", max_files=LIMITS["file_input"]["max_files"]["min"] - 1
+    ),
+    "file-input-max-files-too-large": lambda: FileInput(
+        action_id="a", max_files=LIMITS["file_input"]["max_files"]["max"] + 1
+    ),
+    "plain-text-input-max-length-too-large": lambda: PlainTextInput(
+        action_id="a", max_length=LIMITS["plain_text_input"]["max_length"]["max"] + 1
+    ),
+    "actions-too-many-elements": lambda: ActionsBlock(
+        elements=[
+            Button(text="A", action_id=f"a-{index}")
+            for index in range(LIMITS["actions"]["elements"]["max_items"] + 1)
+        ]
+    ),
+    "context-too-many-elements": lambda: ContextBlock(
+        elements=[Text("A") for _ in range(LIMITS["context"]["elements"]["max_items"] + 1)]
+    ),
+    "header-text-too-long": lambda: HeaderBlock("x" * (LIMITS["header"]["text"]["max_length"] + 1)),
+    "image-url-too-long": lambda: ImageBlock(
+        image_url="x" * (LIMITS["image"]["image_url"]["max_length"] + 1),
+        alt_text="Alt",
+    ),
+    "image-alt-text-too-long": lambda: ImageBlock(
+        image_url="https://example.com/image.png",
+        alt_text="x" * (LIMITS["image"]["alt_text"]["max_length"] + 1),
+    ),
+    "input-label-too-long": lambda: InputBlock(
+        label="x" * (LIMITS["input"]["label"]["max_length"] + 1),
+        element=PlainTextInput(action_id="a"),
+    ),
+    "input-hint-too-long": lambda: InputBlock(
+        label="Label",
+        hint="x" * (LIMITS["input"]["hint"]["max_length"] + 1),
+        element=PlainTextInput(action_id="a"),
+    ),
+    "markdown-empty": lambda: MarkdownBlock(""),
+    "markdown-too-long": lambda: MarkdownBlock(
+        "x" * (LIMITS["markdown"]["text"]["max_length"] + 1)
+    ),
+    "section-text-too-long": lambda: SectionBlock(
+        "x" * (LIMITS["section"]["text"]["max_length"] + 1)
+    ),
+    "section-too-many-fields": lambda: SectionBlock(
+        fields=["x"] * (LIMITS["section"]["fields"]["max_items"] + 1)
+    ),
+    "section-field-too-long": lambda: SectionBlock(
+        fields=["x" * (LIMITS["section"]["fields"]["item_max_length"] + 1)]
+    ),
+    "video-alt-text-empty": lambda: video(alt_text=""),
+    "video-alt-text-too-long": lambda: video(
+        alt_text="x" * (LIMITS["video"]["alt_text"]["max_length"] + 1)
+    ),
+    "video-title-too-long": lambda: video(title="x" * (LIMITS["video"]["title"]["max_length"] + 1)),
+    "video-author-name-too-long": lambda: video(
+        author_name="x" * (LIMITS["video"]["author_name"]["max_length"] + 1)
+    ),
+    "video-description-too-long": lambda: video(
+        description="x" * (LIMITS["video"]["description"]["max_length"] + 1)
+    ),
+    "video-provider-name-too-long": lambda: video(
+        provider_name="x" * (LIMITS["video"]["provider_name"]["max_length"] + 1)
+    ),
+    "view-missing-blocks": lambda: HomeTabView(blocks=[]),
+    "view-too-many-blocks": lambda: HomeTabView(
+        blocks=[DividerBlock() for _ in range(LIMITS["view"]["blocks"]["max_items"] + 1)]
+    ),
+    "view-private-metadata-too-long": lambda: HomeTabView(
+        blocks=[DividerBlock()],
+        private_metadata="x" * (LIMITS["view"]["private_metadata"]["max_length"] + 1),
+    ),
+    "view-callback-id-too-long": lambda: HomeTabView(
+        blocks=[DividerBlock()],
+        callback_id="x" * (LIMITS["view"]["callback_id"]["max_length"] + 1),
+    ),
+    "view-title-too-long": lambda: ModalView(
+        title="x" * (LIMITS["view"]["title"]["max_length"] + 1),
+        blocks=[DividerBlock()],
+    ),
+    "view-close-too-long": lambda: ModalView(
+        title="Title",
+        close="x" * (LIMITS["view"]["close"]["max_length"] + 1),
+        blocks=[DividerBlock()],
+    ),
+    "view-submit-too-long": lambda: ModalView(
+        title="Title",
+        submit="x" * (LIMITS["view"]["submit"]["max_length"] + 1),
+        blocks=[DividerBlock()],
+    ),
     "section-missing-content": lambda: SectionBlock(),
-    "section-text-too-long": lambda: SectionBlock("x" * 3001),
-    "section-too-many-fields": lambda: SectionBlock(fields=["x"] * 11),
-    "section-field-too-long": lambda: SectionBlock(fields=["x" * 2001]),
-    "header-text-too-long": lambda: HeaderBlock("x" * 151),
-    "button-text-too-long": lambda: Button(text="x" * 76, action_id="a"),
-    "button-action-id-too-long": lambda: Button(text="A", action_id="x" * 256),
-    "option-value-too-long": lambda: option("x" * 76),
-    "overflow-too-many-options": lambda: OverflowMenu("a", [option(str(i)) for i in range(6)]),
     "static-select-options-and-groups": lambda: StaticSelectMenu(
         "a",
         options=[option()],
@@ -101,12 +301,17 @@ def option(value: str = "a") -> Option:
     "number-input-inverted-range": lambda: NumberInput(
         is_decimal_allowed=True, min_value=2, max_value=1
     ),
-    "file-input-max-files-out-of-range": lambda: FileInput(action_id="a", max_files=11),
     "context-invalid-element": lambda: ContextBlock(elements=[DividerBlock()]),
     "input-invalid-element": lambda: InputBlock(label="Label", element=Button("A", "a")),
-    "view-missing-blocks": lambda: HomeTabView(blocks=[]),
 }
 
+
+def scalar_paths(value: object, prefix: tuple[str, ...] = ()) -> set[str]:
+    if not isinstance(value, dict):
+        return {".".join(prefix)}
+    return {path for key, nested in value.items() for path in scalar_paths(nested, (*prefix, key))}
+
+
 ERROR_CATEGORIES = {
     LengthError: "length-exceeded",
     RangeError: "out-of-range",
@@ -134,6 +339,23 @@ def test_invalid_case_category(case_id: str, expected_category: str) -> None:
     assert category == expected_category
 
 
+def test_invalid_manifest_covers_every_scalar_limit() -> None:
+    cases = load_json(SPEC_ROOT / "fixtures" / "invalid" / "manifest.json")["cases"]
+    covered = {case["constraint"] for case in cases}
+    assert scalar_paths(LIMITS) <= covered
+
+
+def test_invalid_manifest_has_unique_case_ids_and_constraints() -> None:
+    cases = load_json(SPEC_ROOT / "fixtures" / "invalid" / "manifest.json")["cases"]
+    assert len({case["id"] for case in cases}) == len(cases)
+    assert len({case["constraint"] for case in cases}) == len(cases)
+
+
+def test_every_invalid_case_has_a_python_construction() -> None:
+    cases = load_json(SPEC_ROOT / "fixtures" / "invalid" / "manifest.json")["cases"]
+    assert set(INVALID_CASES) == {case["id"] for case in cases}
+
+
 def test_python_skiplist_is_empty() -> None:
     entries = [
         line