Support multiple markdown processor(redcarpet, pandoc)#15
Open
zonuexe wants to merge 10 commits into
Open
Conversation
- markdown-preview-eww-major-mode-default-dialect - markdown-preview-eww-major-mode-dialect-alist
zonuexe
changed the title
Owner
|
I'm looking forward it! :) |
|
This would resolve #12 |
| (format "require \"redcarpet\" | ||
| (defcustom markdown-preview-eww-convert-command | ||
| nil | ||
| "Symbol of markdown convert function.") |
There was a problem hiding this comment.
If this is a function name, the variable name and defcustom should be as follows (note the default). You should defgroup a customization group and put all defcustoms under it to make the user experience better.
Even nicer to the user is if you give them a choice between the known conversion functions and an arbitrary function.
(defcustom markdown-preview-eww-convert-function 'markdown-preview-eww-convert-command-redcarpet
"*A function that is called to convert the Markdown document to HTML that eww can render"
:group 'markdown-preview-eww
:type 'function)
|
What's needed to merge this pull request? |
zonuexe
force-pushed
the
feature/multi-engine
branch
from
92f5a01 to
241dcf4
Compare
zonuexe
force-pushed
the
feature/multi-engine
branch
from
2f8f7b1 to
224b68f
Compare
Contributor
Author
zonuexe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.