Skip to content

Change SVG export dialog to support bitmap exports w/ PPI - #1950

Merged
cmeyer merged 2 commits into
nion-software:masterfrom
cmeyer:export-display
Sep 9, 2026
Merged

cmeyer merged 2 commits into
nion-software:masterfrom
cmeyer:export-display

Conversation

@cmeyer

@cmeyer cmeyer commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #1852

  • Add export_bitmap_file function; allow font-size override.
  • Change SVG export dialog to support bitmap exports w/ PPI.

AI assisted (dialog).

This is a step to update the existing dialog; follow-ups will consolidate the various export workflows, make exporting modeless (and threaded), etc.

Note: the font size is fixed at 1/6 PPI in this version. PPI for SVG is 96.

The menu item is renamed from Export SVG... to Export SVG/Bitmap... in this PR.

image

@cmeyer
cmeyer force-pushed the export-display branch 2 times, most recently from 65b9c03 to d45311b Compare September 4, 2026 03:36

@MattRoyle MattRoyle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmeyer
cmeyer merged commit fca72f5 into nion-software:master Sep 9, 2026
12 checks passed
@cmeyer
cmeyer deleted the export-display branch September 9, 2026 05:20
@Ion-e

Ion-e commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Issue and special mentions:

  1. No persistence in default selection (Consistently), so making several exports of the same size can be tedious. The only attributes that remain persistent are "SVG/Bitmap image", and "PNG/BMP/JPEG", all other ones reset to default values.
  2. When exporting to SVG, the "File format" drop down remains shown, which is misleading as it states the format will be either PNG/JPEG/BMP. There is an inconsistent use in the UI regarding the drop down enable/disable functionality. A disabled drop down should indicate that the values are not editable, not that the values are not going to be used. This behaviour is inconsistent in this same window between the aforementioned File Format drop down and the PPI drop down values.
  3. Sometimes when swapping from Bitmap to SVG options, you have to click twice which makes me think the cursor loses focus.
  4. It's not clear UI to have the "Custom" option as an option in the "PPI", and then having 2 PPI edit boxes. This should be reworked.
  5. The "Units" expander is not intuitive to be referring to "Width/Height", the UI should be reworked to reflect this, potentially placing the units first as a user is more likely to first select the desired units then select the unit values as standard workflow.
  6. Units drop down and PPI dropdown have different lengths.
  7. Sometimes, when swapping from SVG to Bitmap, the PPI drop down doesn't become enabled automatically, the user has to manually change the Units drop down for it to become enabled.
  8. Export as and File format dropdowns could be merged to "Export as: SVG/BItmap PNG/Bitmap BMP/Bitmap JPEG"
  9. We could change the "Custom" option in the drop down for aspect ratio by adding the Superscan Width/Height button:
Image
  1. How were the Default PPI values chosen?
  2. The custom PPI edit box and PPI drop down could be merged into 1.
  3. The "Default (5:3)" can be changed to "(5:3)".

After this issues have been addressed, a new round of testing should be done on this feature. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exporting with scale bar to bitmap format (PNG, TIFF)

3 participants