Conversation
harseld
commented
Jul 27, 2026
harseld
commented
- New OATAlignmentDevice/OATAlignmentVM/OATAlignment classes, integrating the LX200 OpenAstroTech INDI driver (POLAR_AZ/POLAR_ALT) as a third selectable system alongside UPAS/OAPA.
- AutomatedAdjustmentController: raise the per-move safety ceiling from a fixed 5 arcmin to a 4 deg emergency backstop, letting the existing 0.5/0.25/0.125-damped least-squares correction stay proportional to the measured error instead of being artificially truncated. This is done to allow the process to converge fast enough, as manual positioning of the mount can often induce a large initial error.
- Stall detection: abort automated adjustments with a clear notification if several consecutive commanded moves produce no measurable change in the polar error, instead of looping indefinitely.
- Tested on real sky (Raspberry Pi 4 + PINS + Touch-N-Stars).
- New OATAlignmentDevice/OATAlignmentVM/OATAlignment classes, integrating the LX200 OpenAstroTech INDI driver (POLAR_AZ/POLAR_ALT) as a third selectable system alongside UPAS/OAPA. - AutomatedAdjustmentController: raise the per-move safety ceiling from a fixed 5 arcmin to a 4 deg emergency backstop, letting the existing 0.5/0.25/0.125-damped least-squares correction stay proportional to the measured error instead of being artificially truncated. - Stall detection: abort automated adjustments with a clear notification if several consecutive commanded moves produce no measurable change in the polar error, instead of looping indefinitely. - Tested end-to-end on real sky (Raspberry Pi / PINS + Touch-N-Stars).
Per review feedback from nitr57: PolarAlignmentPlugin.cs and
Settings.Designer.cs carried a lot of incidental reformatting
(BOM removal, get{}->expression-body conversions, blank-line/
alignment changes) that had nothing to do with OAT support and
only made the diff diverge from upstream unnecessarily. Reverted
all of it, keeping only the actual OAT-related additions:
- PolarAlignmentPlugin.cs: OAT wiring (Instance singleton, VM
property, switch arm, IsOATSelected, constructor/reset wiring)
- Settings.Designer.cs: the 8 new OAT setting properties
- csproj: restored the original BOM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.