Add interface argument to Ipv6MembershipRequest::new#2736
Open
Skyb0rg007 wants to merge 1 commit intonix-rust:masterfrom
Open
Add interface argument to Ipv6MembershipRequest::new#2736Skyb0rg007 wants to merge 1 commit intonix-rust:masterfrom
Skyb0rg007 wants to merge 1 commit intonix-rust:masterfrom
Conversation
This commit adds an additional argument to the Ipv6MembershipRequest::new function that allows the user to specify the interface index for which the membership request is associated with. Closes nix-rust#323
Author
|
I guess this is also a duplicate of #2688, with a slightly different API choice. It would be great if one of these PRs were at least reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an additional argument to the
Ipv6MembershipRequest::new function that allows the user to specify the interface index for which the
membership request is associated with.
Closes #323
What does this PR do
This PR revives the efforts of #1320 to add proper support to the IPV6_JOIN_GROUP socket option.
Devices (especially routers) have many IPv6 interfaces, and being able to specify which interfaces to join a multicast group on is critical. Specifying
0(as is currently done) is not portable:Checklist:
CONTRIBUTING.md