Remove portfolio roles during cleanup#270
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Remove only Portfolio Author and portfolio capabilities when the post type is turned off, so managers can still edit Saved Layouts. Full role cleanup remains on uninstall only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove Visual Portfolio custom roles when they are no longer needed.
What changed
register_portfolio_post_typesettingPortfolio AuthorandPortfolio Managerwhen the Portfolio CPT is disableduninstall.phpcleanup to remove plugin roles and capabilities on uninstallVerification
Register Portfolio Post TypePortfolio AuthorandPortfolio Managerdisappear fromUsers > Add Newphp -lfor changed PHP filesNotes
This follows the explicit create/remove role lifecycle pattern used by WooCommerce, instead of only adding capabilities on
init.