fix(security): change default encryption engine from AES-CBC to AES-GCM#7
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
The EncryptedType in sqlalchemy-utils uses AES-CBC with a static IV by default (Safety DB 42194 / PVE-2021-42194). This vulnerability affects all versions >=0.27.0 and has no upstream fix (PR apache#499 remains unmerged). Rather than a version bump (which cannot resolve the issue), this changes Superset's default encryption engine from 'aes' (AES-CBC, static IV) to 'aes-gcm' (AES-GCM, random IV + authenticated encryption). Existing deployments that relied on the implicit 'aes' default must either: - Set SQLALCHEMY_ENCRYPTED_FIELD_ENGINE='aes' explicitly to retain the previous behavior, or - Run 'superset re-encrypt-secrets' to migrate stored ciphertext to AES-GCM. Closes #2 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the
sqlalchemy-utilsEncryptedType static-IV vulnerability (Safety DB 42194 / PVE-2021-42194). Fixes #2.Why a version bump doesn't work: The vulnerability affects all
sqlalchemy-utilsversions>=0.27.0. The upstream fix (PR kvesteri/sqlalchemy-utils#499) has remained unmerged since Feb 2021. The latest release (0.42.1) is still affected. The Safety DB's "upgrade to 0.1" recommendation is erroneous.What this PR does instead: Changes
DEFAULT_ENCRYPTION_ENGINE_NAMEfrom"aes"(AES-CBC with a static IV — the vulnerable default) to"aes-gcm"(AES-GCM withos.urandomIVs + authenticated encryption). This directly eliminates the vulnerability for any deployment that doesn't explicitly override the engine.Compatibility considerations:
SQLALCHEMY_ENCRYPTED_FIELD_ENGINE = "aes"explicitly are unaffected (they keep AES-CBC).superset re-encrypt-secrets --previous-secret-key <KEY>(theSecretsMigratorin this file already handles CBC→GCM transitions).SQLALCHEMY_ENCRYPTED_FIELD_ENGINE = "aes"to explicitly opt back into the previous behavior.Link to Devin session: https://app.devin.ai/sessions/ba8cecfc1286455f99d874887af73fa2
Requested by: @noahlin17