Skip to content

Commit c570b67

Browse files
panvanodejs-github-bot
authored andcommitted
test: unmark loader inspector wait test as flaky
Disconnecting the inspector can race with its final notification write. If EOF resets the socket first, the write used to dereference a null TCP handle. 8a84e6b added guards for writes after disconnect. Removing those guards reproduces the loader test's SIGSEGV under a scheduling-delay probe; the normal binary passes the same probe. Remove the flaky expectations left over from before that fix. Refs: #54346 Refs: #34833 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66319 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent c12d483 commit c570b67

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

‎test/parallel/parallel.status‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ test-fs-cp-async-symlink-points-to-dest: SKIP
2727
[$system==win32 && $arch==arm64]
2828

2929
[$system==linux]
30-
# https://github.com/nodejs/node/issues/54346
31-
test-esm-loader-hooks-inspect-wait: PASS, FLAKY
3230

3331
[$system==macos]
3432
# https://github.com/nodejs/node/issues/42741
@@ -58,8 +56,6 @@ test-domain-no-error-handler-abort-on-uncaught-8: PASS, FLAKY
5856
test-domain-no-error-handler-abort-on-uncaught-9: PASS, FLAKY
5957
test-domain-throw-error-then-throw-from-uncaught-exception-handler: PASS, FLAKY
6058
test-domain-with-abort-on-uncaught-exception: PASS, FLAKY
61-
# https://github.com/nodejs/node/issues/54346
62-
test-esm-loader-hooks-inspect-wait: PASS, FLAKY
6359
# https://github.com/nodejs/node/issues/61520
6460
test-fs-promises-watch-iterator: SKIP
6561
test-fs-promises-watch-ignore-function: SKIP
@@ -74,8 +70,6 @@ test-fs-watch-ignore-regexp: SKIP
7470
test-tick-processor-arguments: SKIP
7571

7672
[$system==freebsd]
77-
# https://github.com/nodejs/node/issues/54346
78-
test-esm-loader-hooks-inspect-wait: PASS, FLAKY
7973
# https://github.com/nodejs/node/issues/61520
8074
test-fs-promises-watch-iterator: SKIP
8175
test-fs-promises-watch-ignore-function: SKIP
@@ -88,8 +82,6 @@ test-fs-watch-ignore-mixed: SKIP
8882
test-fs-watch-ignore-regexp: SKIP
8983

9084
[$system==aix]
91-
# https://github.com/nodejs/node/issues/54346
92-
test-esm-loader-hooks-inspect-wait: PASS, FLAKY
9385

9486
[$system==ibmi]
9587
# https://github.com/nodejs/node/pull/30819

0 commit comments

Comments
 (0)