test: avoid flaky restart sync in debugger exceptions test#62055
Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
Open
test: avoid flaky restart sync in debugger exceptions test#62055inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
217a40b to
bfe5f1b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62055 +/- ##
==========================================
+ Coverage 89.58% 89.64% +0.06%
==========================================
Files 674 676 +2
Lines 205159 206240 +1081
Branches 39352 39507 +155
==========================================
+ Hits 183792 184891 +1099
+ Misses 13583 13466 -117
- Partials 7784 7883 +99 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the same flaky debugger restart race as #61773.
In
test/parallel/test-debugger-exceptions.js, usingstepCommand('r')can intermittently time out while waiting forBREAK_MESSAGE.For
r, this PR switches restart sync to prompt-first waiting (command('r')) and then waits forwaitForInitialBreak(), keeping test intent unchanged.failed CI logs:
Testing
./tools/test.py -p actions parallel/test-debugger-exceptions./tools/test.py -p actions -j1 --repeat 40 parallel/test-debugger-exceptions./tools/test.py -p actions parallel/test-debugger-restart-message parallel/test-debugger-run-after-quit-restartRefs: #61762