Skip to content

test: avoid flaky restart sync in debugger exceptions test#62055

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-test-debugger-exceptions
Open

test: avoid flaky restart sync in debugger exceptions test#62055
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-test-debugger-exceptions

Conversation

@inoway46
Copy link
Contributor

@inoway46 inoway46 commented Mar 1, 2026

Summary

This PR addresses the same flaky debugger restart race as #61773.

In test/parallel/test-debugger-exceptions.js, using stepCommand('r') can intermittently time out while waiting for BREAK_MESSAGE.
For r, this PR switches restart sync to prompt-first waiting (command('r')) and then waits for waitForInitialBreak(), keeping test intent unchanged.

failed CI logs:

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"
  • ./tools/test.py -p actions parallel/test-debugger-exceptions
  • ./tools/test.py -p actions -j1 --repeat 40 parallel/test-debugger-exceptions
  • ./tools/test.py -p actions parallel/test-debugger-restart-message parallel/test-debugger-run-after-quit-restart
  • CI passes on macOS

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 1, 2026
@inoway46 inoway46 force-pushed the fix-flaky-test-debugger-exceptions branch from 217a40b to bfe5f1b Compare March 1, 2026 04:18
@inoway46 inoway46 marked this pull request as ready for review March 1, 2026 04:20
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (6a3d358) to head (bfe5f1b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62055      +/-   ##
==========================================
+ Coverage   89.58%   89.64%   +0.06%     
==========================================
  Files         674      676       +2     
  Lines      205159   206240    +1081     
  Branches    39352    39507     +155     
==========================================
+ Hits       183792   184891    +1099     
+ Misses      13583    13466     -117     
- Partials     7784     7883      +99     

see 124 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants